[fix-finder] Remove unused `using` directives in `CheckForInvalidResourceFileNames.cs` and `CreateDynamicFeatureManifest.cs`

[github-actions]

Problem

Two MSBuild task files have accumulated many unused using directives over time — 8 of 13 in one file, 6 of 11 in the other. Removing them improves readability and reduces noise.

Location

• File 1: src/Xamarin.Android.Build.Tasks/Tasks/CheckForInvalidResourceFileNames.cs
• File 2: src/Xamarin.Android.Build.Tasks/Tasks/CreateDynamicFeatureManifest.cs

Current Code — CheckForInvalidResourceFileNames.cs

#nullable enable
using System;
using System.Diagnostics;          // ← unused
using System.IO;
using System.Linq;                 // ← unused
using System.Threading;            // ← unused
using System.Xml;                  // ← unused
using System.Xml.Linq;            // ← unused
using Microsoft.Build.Utilities;   // ← unused
using Microsoft.Build.Framework;
using System.Text.RegularExpressions;
using System.Collections.Generic;  // ← unused
using Xamarin.Android.Tasks;       // ← redundant (file is in this namespace)
using Microsoft.Android.Build.Tasks;

Current Code — CreateDynamicFeatureManifest.cs

#nullable enable
using System;
using System.Collections.Generic;  // ← unused
using System.Diagnostics;          // ← unused
using System.IO;                   // ← unused
using System.Linq;                 // ← unused
using System.Xml;                  // ← unused (only System.Xml.Linq types are used)
using System.Xml.Linq;
using Microsoft.Build.Utilities;   // ← unused
using Microsoft.Build.Framework;

using Xamarin.Android.Tools;
using Microsoft.Android.Build.Tasks;

Suggested Fix

CheckForInvalidResourceFileNames.cs — keep only:

#nullable enable
using System;
using System.IO;
using System.Text.RegularExpressions;
using Microsoft.Build.Framework;
using Microsoft.Android.Build.Tasks;

CreateDynamicFeatureManifest.cs — keep only:

#nullable enable
using System;
using System.Xml.Linq;
using Microsoft.Build.Framework;

using Xamarin.Android.Tools;
using Microsoft.Android.Build.Tasks;

Guidelines

• Do not reorder the remaining using directives beyond removing unused ones
• Ensure the project still compiles after changes
• Preserve existing blank-line grouping style between remaining usings

Acceptance Criteria

• All unused using directives listed above are removed from both files
• The redundant self-namespace using Xamarin.Android.Tasks; is removed from CheckForInvalidResourceFileNames.cs
• The project Xamarin.Android.Build.Tasks builds without errors (dotnet build src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj)
• No new warnings introduced

Generated by Nightly Fix Finder · ● 4.3M · ◷

• expires on May 25, 2026, 9:21 PM UTC