[infra] fix destory workfllow

Author: vivekgsharma

.github/workflows/destroy-devnet.yml

@@ -190,6 +190,9 @@ jobs:
           echo ""
 
       - name: Destroy devnet
+        env:
+          TF_IN_AUTOMATION: "true"
+          TF_CLI_ARGS_destroy: "-auto-approve"
         run: |
           chmod +x ./bin/destroy
           ./bin/destroy "$NETWORK_NAME" -t="$DESTROY_TARGET"

ansible/roles/dashd/defaults/main.yml

@@ -16,3 +16,6 @@ dashd_allowprivatenet: '{% if dashd_externalip | ansible.utils.ipaddr("private")
 
 dashd_compose_project_name: dashcore
 dashd_compose_path: '{{ dashd_home }}/{{ dashd_compose_project_name }}'
+
+# Wallet operations are only enabled on dedicated wallet nodes.
+enable_wallet: false

ansible/roles/dashd/tasks/main.yml

@@ -101,7 +101,7 @@
     block: |
       wallet={{ wallet_rpc_wallet_faucet }}
       wallet={{ wallet_rpc_wallet_mno }}
-  when: enable_wallet is true and wallet_exists.stat.exists is true
+  when: (enable_wallet | default(false) | bool) and wallet_exists.stat.exists is true
 
 # TODO: why does this always take exactly 30 seconds on first deploy?
 - name: Start dash core
@@ -126,14 +126,14 @@
     cmd: dash-cli createwallet {{ wallet_rpc_wallet_faucet }}
     creates: "{{ dashd_home }}/.dashcore/{{ dash_network_name if dash_network == 'devnet' else 'testnet3' }}/wallets/{{ wallet_rpc_wallet_faucet }}/wallet.dat"
   register: create_faucet_wallet_result
-  when: enable_wallet is true
+  when: enable_wallet | default(false) | bool
 
 - name: Create mno wallet
   ansible.builtin.command:
     cmd: dash-cli createwallet {{ wallet_rpc_wallet_mno }}
     creates: "{{ dashd_home }}/.dashcore/{{ dash_network_name if dash_network == 'devnet' else 'testnet3' }}/wallets/{{ wallet_rpc_wallet_mno }}/wallet.dat"
   register: create_mno_wallet_result
-  when: enable_wallet is true
+  when: enable_wallet | default(false) | bool
 
 - name: Load wallets on startup
   ansible.builtin.blockinfile:
@@ -142,10 +142,13 @@
     block: |
       wallet={{ wallet_rpc_wallet_faucet }}
       wallet={{ wallet_rpc_wallet_mno }}
-  when: create_faucet_wallet_result.changed and create_mno_wallet_result.changed
+  when: >
+    (enable_wallet | default(false) | bool) and
+    (create_faucet_wallet_result is defined and create_faucet_wallet_result.changed) and
+    (create_mno_wallet_result is defined and create_mno_wallet_result.changed)
 
 - name: Import faucet privkey
   ansible.builtin.command: dash-cli -rpcwallet={{ wallet_rpc_wallet_faucet }} importprivkey {{ faucet_privkey }}
   register: result
-  when: enable_wallet is true
+  when: enable_wallet | default(false) | bool
   changed_when: result.rc == 0