Skip to content

disk fixity can crash when package deleted after checklist generated #5

Description

@grf

the disk was being fixity checked when the file was deleted on a refresh; bad timing, it disappeared out from under the check. It should be easy to fix the bug (just needs to catch the error and double check if it was deleted and then either:

  1. log an error and record it as missing and move on, or
  2. just move on if it really was properly deleted
/opt/web-services/sites/silos/current/lib/store/silo.rb:307:in `md5': Can't determine md5 for 'E20060816_AAACGI' (located at '/daitssfs/007/68f/ab940396a03793eb754264bc88a34'): No such file or directory - /daitssfs/007/68f/ab940396a03793eb754264bc88a34/md5 (Store::SiloError)
       from /opt/web-services/sites/silos/current/lib/store/silo.rb:403:in `read_lock'
       from /opt/web-services/sites/silos/current/lib/store/silo.rb:401:in `open'
       from /opt/web-services/sites/silos/current/lib/store/silo.rb:401:in `read_lock'
       from /opt/web-services/sites/silos/current/lib/store/silo.rb:303:in `md5'
       from /opt/web-services/sites/silos/current/tools/disk-fixity:195
       from /opt/web-services/sites/silos/current/lib/store/silodb.rb:141:in `each_package_record'
       from /opt/web-services/sites/silos/shared/bundle/ruby/1.8/gems/dm-core-1.2.0/lib/dm-core/collection.rb:507:in `each'
       from /opt/web-services/sites/silos/shared/bundle/ruby/1.8/gems/dm-core-1.2.0/lib/dm-core/support/lazy_array.rb:411:in `each'
       from /opt/web-services/sites/silos/shared/bundle/ruby/1.8/gems/dm-core-1.2.0/lib/dm-core/support/lazy_array.rb:411:in `each'
       from /opt/web-services/sites/silos/shared/bundle/ruby/1.8/gems/dm-core-1.2.0/lib/dm-core/collection.rb:504:in `each'
       from /opt/web-services/sites/silos/current/lib/store/silodb.rb:141:in `each_package_record'
       from /opt/web-services/sites/silos/current/tools/disk-fixity:158
       from /opt/web-services/sites/silos/current/tools/disk-fixity:152:in `each'
       from /opt/web-services/sites/silos/current/tools/disk-fixity:152

[prb.fcla.edu #15324]

[core] disk-fixity: repeated crashes (#603)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions