fix: address type checking review comments

- Add type annotations to smart_open in git.py
- Add type: ignore[attr-defined] for Template.substitute call
- Cast dict to ChangelogArgs in bump.py
- Cast dynamic key dict to VersionArgs in test_version_command.py

Co-authored-by: Copilot <[email protected]>

Author: bearomorphism

commitizen/commands/bump.py

@@ -323,7 +323,10 @@ def __call__(self) -> None:
                 try:
                     Changelog(
                         self.config,
-                        {**changelog_args, "dry_run": True},
+                        cast(
+                            "ChangelogArgs",
+                            {**changelog_args, "dry_run": True},
+                        ),
                     )()
                 except DryRunExit:
                     pass

commitizen/cz/customize/customize.py

@@ -55,7 +55,7 @@ def questions(self) -> list[CzQuestion]:
     def message(self, answers: Mapping[str, Any]) -> str:
         message_template = Template(self.custom_settings.get("message_template", ""))
         if getattr(Template, "substitute", None):
-            return message_template.substitute(
+            return message_template.substitute(  # type: ignore[attr-defined]
                 **answers
             )  # pragma: no cover # TODO: check if we can fix this
         return message_template.render(**answers)

commitizen/git.py

@@ -5,6 +5,7 @@
 from functools import lru_cache
 from pathlib import Path
 from tempfile import NamedTemporaryFile
+from typing import IO, Any
 
 from commitizen import cmd, out
 from commitizen.exceptions import GitCommandError
@@ -316,7 +317,7 @@ def get_core_editor() -> str | None:
     return None
 
 
-def smart_open(*args, **kwargs):  # noqa: ANN201
+def smart_open(*args: Any, **kwargs: Any) -> IO[Any]:  # noqa: ANN401
     """Open a file with the EOL style determined from Git."""
     return open(*args, newline=EOLType.for_open(), **kwargs)
 

tests/commands/test_version_command.py

@@ -1,11 +1,13 @@
 import platform
 import sys
+from typing import cast
 
 import pytest
 from pytest_mock import MockerFixture
 
 from commitizen import commands
 from commitizen.__version__ import __version__
+from commitizen.commands.version import VersionArgs
 from commitizen.config.base_config import BaseConfig
 
 
@@ -151,9 +153,7 @@ def test_version_just_minor(config, capsys, version: str, expected_version: str)
 def test_version_just_major_error_no_project(config, capsys, argument: str):
     commands.Version(
         config,
-        {
-            argument: True,
-        },
+        cast("VersionArgs", {argument: True}),
     )()
     captured = capsys.readouterr()
     assert not captured.out