|
$provider = config("modules.location.$location.provider", 'Providers\\ModuleServiceProvider'); |
Hi,
I stumbled about the following issue. In the RepositoryManager (see referenced file) the config-value for "modules.location.$location.provider" will never be loaded, since the key in the Config-File "modules.php" is "locations" and not "location". So it always uses the Default-Value here, which is ok, as long as I do not change the name of the ModuleServiceProvider. As soon as I change the name to something else e.g. AddOnServiceProvider, the module can not load properly, since the class was not found.
I temporarly fixed the config-key, but then the namespace "Providers" is missing in the classname. I hope this makes sense. Feel free to contact me for further questions. :)
Thanks,
Steffen
modules/src/RepositoryManager.php
Line 70 in e33e4b7
Hi,
I stumbled about the following issue. In the RepositoryManager (see referenced file) the config-value for "modules.location.$location.provider" will never be loaded, since the key in the Config-File "modules.php" is "locations" and not "location". So it always uses the Default-Value here, which is ok, as long as I do not change the name of the ModuleServiceProvider. As soon as I change the name to something else e.g. AddOnServiceProvider, the module can not load properly, since the class was not found.
I temporarly fixed the config-key, but then the namespace "Providers" is missing in the classname. I hope this makes sense. Feel free to contact me for further questions. :)
Thanks,
Steffen