Skip to content

keyJson has incorrect datastructure #40

Description

@bootstrapsp

Describe the bug
CreateKey method in DID request message DidCreateKeyRequest{
int64 WalletHandle = 1;
string KeyJson = 2;

KeyJson should be a complex dataType with Seed and Crypto as string

To Reproduce
NA

Expected behavior
Proto should have definition :

message DidCreateKeyRequest{
  int64 WalletHandle = 1;
  KeyJson KeyJson = 2;
}

message KeyJson{
string seed = 1;
string crypto = 2;
}

Additional context
There are more than one usage of KeyJson , i.e. there are multiple services like from Crypto, DID that uses KeyJson message. Therefore, individual messages should be created rather than re-using them between services.

This will require proto change as well as update on server and client side.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions