Skip to content
This repository was archived by the owner on Dec 30, 2024. It is now read-only.
This repository was archived by the owner on Dec 30, 2024. It is now read-only.

Settings Model SpecialDict needs fixing #37

Description

@benhoff

I haven't parsed through what the original logic or reasoning behind checking to see if an item does not equal a tuple, but I'm pretty sure the logic is fundamentally broken.
See: https://github.com/benhoff/CHATIMUSMAXIMUS/blob/master/chatimusmaximus/gui/models/settings_model.py#L54

I think this check needs to be changed to see if the item is an instance of a tuple (or probably better, an iterable) and then see if it is non-empty.

Also the class name is awful.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions