`ContentTypeNegotiation` plug too strict about `accept` header?

[grzuy]

Hi there 👋

Noticed that for a POST request, the JSONAPI.ContentTypeNegotiation plug will return 406 unless accept header is set to:

• application/vnd.api+json OR
• not set at all

But why is that accept: */* or even accept: application/json is not acceptable?

Is there anything in the spec (https://jsonapi.org/format/#content-negotiation) stating that the client MUST provide an accept header with those strict conditions during POST?

Thanks!

[grzuy]

Demo test for this case in #455.

[mattpolzin]

The spec defines a media type that a server must respond with so the server cannot satisfy Accept: application/json. It does seem like Accept: */* should be fine though.

Note you can also omit the content type check or use your own (which my company does so we can be more lenient).

[grzuy]

Hi @mattpolzin ,

Thanks.

Note I am not referring to the content-type check, which seems to be on spec.
I am only referring to the validation of the accept header value for POST, PATCH and `PUT.

[mattpolzin]

Yeah, but if the server must respond with application/vnd.api+json and the client will only accept application/json then the server cannot satisfy the client's request. Technically. Like I said, we choose to be lenient about that where I work.

[grzuy]

Fair enough about a client strictly requesting accept: application/json.

But the ContentTypeNegotiation plug (or EnsureSpec which calls the former) is still returning 406 Not Acceptable when the client requests accept: */*, which is a client stating that it accepts any media type, right?

[mattpolzin]

Yeah, I agree that accepting any media type should be fine with this library's validations.