Fix malformed CQL from spatial filters#369
Merged
Merged
Conversation
ateucher
reviewed
Jun 23, 2026
Co-authored-by: Andy Teucher <[email protected]>
Collaborator
Author
|
Thanks @ateucher. Have a look at the changes. Also note I fixed those instances of |
ateucher
approved these changes
Jun 23, 2026
Collaborator
|
LGTM thanks @boshek! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
filter()calls using CQL geometry predicates (such asINTERSECTS()) produced malformed CQL that the server rejected with a 400 error.The reason the CQL was malformed was because CQL leaked a spurious
TRUE AS "drop_null"clause and extra parentheses following the removal ofc.sql()method in dbplyr 2.6.0 (tidyverse/dbplyr#1691).Closes (#368)