Skip to content

Remove dead, stale DETECTORS list in cli.py #1

Description

@bamdadd

Context

src/taintline/cli.py:11 defines a module-level DETECTORS list that is never referenced anywhere in the codebase, and it is also stale — it lists 5 detectors but the real registry (src/taintline/detectors/__init__.py) now has 6 (missing budget-overrun). The CLI help text already derives the detector list from ALL (cli.py:46), so this constant is dead and misleading.

Confirm with:

grep -rn 'DETECTORS' src tests demo docs

Only the definition shows up — no usage.

What to do

Delete the unused DETECTORS = [...] line at src/taintline/cli.py:11. Nothing imports or reads it. (If you'd rather keep a single source of truth for docs, derive it from sorted(ALL) instead of hand-maintaining a second list — but a plain delete is the accepted fix.)

Acceptance criteria

  • grep -rn 'DETECTORS' src returns no hits (or only a derived-from-ALL expression).
  • uv run taintline check demo/traces/taint_flow.otlp.json --fail-on taint still works and --help still shows the full detector list.
  • uv run pytest stays green.

Pointers

  • src/taintline/cli.py:11 — the dead constant
  • src/taintline/detectors/__init__.py:21-29 — the real registry (ALL)
  • README "Detectors" table lists all 6

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: infraCI / tooling / packaginggood first issueSelf-contained, <2h, clear acceptance + file pointersize: SAn afternoontype: bugSomething is broken or incorrect

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions