fix(assets): tolerate partial SEP request failures

Author: attid

bot/infrastructure/services/anchor_transaction_service.py

@@ -3,6 +3,7 @@
 from urllib.parse import urlencode
 import asyncio
 
+from loguru import logger
 from stellar_sdk import Keypair, TransactionEnvelope
 
 from core.models.anchor_asset import AnchorAssetSupport, SepProtocolSupport
@@ -55,8 +56,14 @@ async def fetch_transactions(
                 support.asset.code,
                 headers,
             ),
+            return_exceptions=True,
         )
-        transactions = [tx for protocol_txs in results for tx in protocol_txs]
+        transactions = []
+        for result in results:
+            if isinstance(result, Exception):
+                logger.info(f"SEP transactions request failed: {result}")
+                continue
+            transactions.extend(result)
         return transactions
 
     async def _authenticate(
@@ -140,5 +147,17 @@ async def _default_fetch_json(
             timeout=self._request_timeout,
         )
         if response.status >= 400 or not isinstance(response.data, dict):
-            raise ValueError(f"Unexpected JSON response from {url}: {response.status}")
+            raise AnchorTransactionRequestError(
+                url=url,
+                status=response.status,
+                body=response.data,
+            )
         return response.data
+
+
+class AnchorTransactionRequestError(Exception):
+    def __init__(self, *, url: str, status: int, body: object) -> None:
+        self.url = url
+        self.status = status
+        self.body = body
+        super().__init__(f"Unexpected JSON response from {url}: {status}; body={body}")

bot/tests/infrastructure/test_anchor_transaction_service.py

@@ -5,7 +5,11 @@
 
 from core.domain.value_objects import Asset
 from core.models.anchor_asset import AnchorAssetSupport, SepProtocol, SepProtocolSupport
-from infrastructure.services.anchor_transaction_service import AnchorTransactionService
+from core.models.anchor_transaction import AnchorTransactionProtocol
+from infrastructure.services.anchor_transaction_service import (
+    AnchorTransactionRequestError,
+    AnchorTransactionService,
+)
 
 
 @pytest.mark.asyncio
@@ -65,3 +69,37 @@ async def fetch_json(method, url, params, headers, data):
     assert transactions[1].protocol.value == "SEP-24"
     assert calls[("GET", "https://anchor.test/sep6/transactions")] == 1
     assert calls[("GET", "https://anchor.test/sep24/transactions")] == 1
+
+
+@pytest.mark.asyncio
+async def test_fetch_transactions_keeps_successful_protocol_when_other_fails():
+    async def fetch_json(method, url, params, headers, data):
+        if url == "https://anchor.test/sep6/transactions":
+            raise AnchorTransactionRequestError(
+                url=url,
+                status=403,
+                body={"type": "authentication_required"},
+            )
+        if url == "https://anchor.test/sep24/transactions":
+            return {"transactions": [{"id": "sep24-1", "status": "completed"}]}
+        raise AssertionError(f"unexpected URL: {url}")
+
+    service = AnchorTransactionService(fetch_json=fetch_json)
+    support = AnchorAssetSupport(
+        asset=Asset("yXLM", "GISSUER"),
+        anchor_domain="anchor.test",
+        web_auth_endpoint=None,
+        sep6=SepProtocolSupport(
+            protocol=SepProtocol.SEP6,
+            transfer_server="https://anchor.test/sep6",
+        ),
+        sep24=SepProtocolSupport(
+            protocol=SepProtocol.SEP24,
+            transfer_server="https://anchor.test/sep24",
+        ),
+    )
+
+    transactions = await service.fetch_transactions(support, Keypair.random())
+
+    assert [tx.id for tx in transactions] == ["sep24-1"]
+    assert transactions[0].protocol is AnchorTransactionProtocol.SEP24

docs/exec-plans/completed/2026-05-23-sep-requests-partial-failures.md

@@ -0,0 +1,54 @@
+# sep-requests-partial-failures: Handle partial SEP request failures
+
+## Context
+
+Ultra Capital returns `403 {"type":"authentication_required"}` from
+`/sep6/transactions?asset_code=yXLM` in the current flow. The Requests button
+should not fail the whole screen when one protocol endpoint rejects the request,
+and logs should include enough response details to diagnose anchor behavior.
+
+## Files/Directories To Change
+
+- `bot/infrastructure/services/anchor_transaction_service.py`
+- `bot/tests/infrastructure/test_anchor_transaction_service.py`
+- `docs/exec-plans/active/2026-05-23-sep-requests-partial-failures.md`
+
+## Edit Permission
+
+- [x] Allowed paths confirmed by user.
+- [x] No edits outside listed paths.
+
+Permission evidence (copy user wording or exact confirmation):
+
+> ладно давай кнопку добьем не работает  Could not load requests.
+> Unexpected JSON response from https://ultracapital.xyz/sep6/transactions?asset_code=yXLM: 403
+> в логе пусто
+
+## Change Plan
+
+1. [x] Add explicit SEP request error type with status/body context.
+2. [x] Catch per-protocol transaction failures, log them, and continue with
+   successful protocol results.
+3. [x] Add regression coverage for one protocol failing while another returns
+   transactions.
+4. [x] Run focused tests and `just check-fast`.
+
+## Risks / Open Questions
+
+- If both protocol endpoints reject the request, the user will still see no
+  requests; logs will now contain the status/body details.
+
+## Verification
+
+- `uv run pytest bot/tests/infrastructure/test_anchor_transaction_service.py -q`
+  - `2 passed in 0.45s`
+- `uv run ruff check bot/infrastructure/services/anchor_transaction_service.py bot/tests/infrastructure/test_anchor_transaction_service.py`
+  - `All checks passed!`
+- `just check-fast`
+  - `ruff check .`: `All checks passed!`
+  - `mypy core`: `Success: no issues found in 28 source files`
+  - `pytest tests/core tests/infrastructure tests/other -m "not integration"`:
+    `415 passed in 5.19s`
+  - `check_import_boundaries.py`: `Import boundary checks passed.`
+  - `check_docs_contract.py`: `Docs contract checks passed.`
+  - `check_exec_plan_scope_lock.py`: `Execution plan scope-lock checks passed.`