Skip to content

the notify hook is wired and silent: this home has no config/notify channel #141

Description

@atqamz

#80 landed the notification hook at d1359010. It fires on blocked, failed,
needs-decision and done, reads /home/atqa/secondhand/config/notify, and that file does not exist -
this home has only harness, model and stale-threshold.

With it absent the hook stays quiet by design. So the mechanism is wired and reaches nobody, which is the exact
scenario #80 was filed for: work continuing while nobody is watching, and nobody being told.

What is needed

A channel. ntfy topic or otherwise - one line is enough and I will wire it.

I am not choosing it myself. The template decides where a message physically goes, that is outward-facing, and
which of Atqa's four profiles it should reach is not derivable from the code.

What is already verified, so this is only the channel

The review raised an exit-1-on-unconfigured contract, and I checked whether an unconfigured home costs the
watcher itself. It does not:

  • NotifyFilter() reads no config field, and cfg.EventFilter gates only the stdout write, with notifyEvent
    running unconditionally after it. So hand watch --event done cannot silence a failed, blocked or
    needs-decision notification, and there is a test pinning that.
  • Both functions are void with no return path into the poll loop, so a failing notify cannot stop the watcher
    ticking or printing.
  • ErrNotConfigured is the one branch that prints nothing, so an unconfigured home does not spew a warning per
    event per poll.

Why this is an issue rather than a note in a file

It was carried in data/inbox.md, which #64 deleted on the grounds that every section of it
had a real home already. "Open threads" map to issues, so this is that.

Related: #80
Related: #64

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions