Skip to content

Commit 1ee301d

Browse files
authored
Merge pull request #34 from atom-community/bundle-eslint
2 parents 86f8001 + c9b408b commit 1ee301d

4 files changed

Lines changed: 202 additions & 120 deletions

File tree

README.md

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,25 @@ This includes the Eslint configuration used in atom-ide-community.
1010
npm install --save-dev eslint-config-atomic
1111
```
1212

13-
You should also install the peer dependencies:
13+
<details>
14+
<summary> You should have the peer dependencies. </summary>
15+
16+
If using `npm`, the bundled Eslint, TypeScript, Babel, etc is hoisted automatically.
17+
18+
If using `pnpm`, either add the following to your `.npmrc` to hoist the prettier bundled with the config
1419

1520
```
16-
npm install -save-dev "eslint"
21+
public-hoist-pattern[]=*
1722
```
1823

24+
Or install these yourself in your `devDependencies`.
25+
26+
```
27+
pnpm install -save-dev eslint typescript @babel/core
28+
```
29+
30+
</details>
31+
1932
## Usage
2033

2134
Create a `.eslintrc.json` file at the root of the project with the following content:

package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@
3232
"bump": "ncu -u -x coffeescript"
3333
},
3434
"dependencies": {
35+
"eslint": "^7",
3536
"@babel/core": "^7",
36-
"@typescript-eslint/eslint-plugin": "^4.18.0",
37-
"@typescript-eslint/parser": "^4.18.0",
37+
"@typescript-eslint/eslint-plugin": "^4.21.0",
38+
"@typescript-eslint/parser": "^4.21.0",
3839
"babel-eslint": "^10.1.0",
3940
"coffeescript": "^1",
4041
"eslint-config-prettier": "^8.1.0",
@@ -45,7 +46,7 @@
4546
"eslint-plugin-node": "^11.1.0",
4647
"eslint-plugin-only-warn": "^1.0.2",
4748
"eslint-plugin-optimize-regex": "^1.2.0",
48-
"eslint-plugin-react": "^7.22.0",
49+
"eslint-plugin-react": "^7.23.1",
4950
"eslint-plugin-yaml": "^0.4.1",
5051
"prettier": "^2",
5152
"typescript": "^4"
@@ -56,7 +57,7 @@
5657
"devDependencies": {
5758
"eslint": "^7.22.0",
5859
"execa": "^5.0.0",
59-
"gitly": "^2.0.2",
60+
"gitly": "^2.0.3",
6061
"npm-check-updates": "11.3.0",
6162
"prettier-config-atomic": "^1.0.1",
6263
"shelljs": "^0.8.4"

0 commit comments

Comments
 (0)