Merge pull request #31 from atom-ide-community/fix/datatip-leftovers

fix: datatip leftovers, max-height for large documentation

Author: appelgriebsch

lib/datatip-manager.js

@@ -313,14 +313,19 @@ module.exports = class DatatipManager {
           else if (result.markedStrings.length > 0) {
             let s = result.markedStrings.map((m) => {
               if (m.type === "markdown") return m.value;
-              const regExpLSPPrefix = /^\((method|property|parameter)\)\W/;
+              const regExpLSPPrefix = /^\((method|property|parameter|alias)\)\W/;
               const snippet = m.value.replace(regExpLSPPrefix, '');
               return `<pre><code class="${editor.getGrammar().name.toLowerCase()}">${snippet}</code></pre>`;
             }).join('\r\n');
             this.renderer.render(s).then((html) => {
-              dataTipView = new DataTipView({ htmlView: html });
-              this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, result.range, position, dataTipView);
-            }).catch((err) => console.log(err));
+              if (result.range.containsRange(this.currentMarkerRange)) {
+                dataTipView = new DataTipView({ htmlView: html });
+                this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, result.range, position, dataTipView);
+              }
+            }).catch((err) => {
+              this.hideDataTip();
+              console.error(err)
+            });
           }
         });
     }

styles/atom-ide-datatips-marked.less

@@ -10,6 +10,7 @@
   font-family: var(--editor-font-family);
   font-size: var(--editor-font-size);
   max-width: 800px;
+  max-height: 400px;
   overflow: auto;
   padding: 8px;
   white-space: normal;

styles/atom-ide-datatips.less

@@ -11,12 +11,13 @@
   white-space: normal;
   pointer-events: all;
   max-width: 800px;
+  max-height: 400px;
   overflow: none;
-  
+
   p {
     margin-left: 8px;
     margin-right: 8px;
-    
+
     &:last-child { margin-bottom: 8px; }
   }
 }