Skip to content

Commit 69b4e60

Browse files
Merge pull request #26 from atom-ide-community/fix/dependency-installation
fix: #25
2 parents b77d62c + 6b1e399 commit 69b4e60

2 files changed

Lines changed: 10 additions & 12 deletions

File tree

lib/datatip-manager.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@ module.exports = class DatatipManager {
1111
* [subscriptions description]
1212
* @type {CompositeDisposable}
1313
*/
14-
this.subscriptions = null;
14+
this.subscriptions = new CompositeDisposable();
1515
/**
1616
* [providerRegistry description]
1717
* @type {ProviderRegistry}
1818
*/
19-
this.providerRegistry = null;
19+
this.providerRegistry = new ProviderRegistry();
2020
/**
2121
* [watchedEditors description]
2222
* @type {Array<TextEditor>}
2323
*/
24-
this.watchedEditors = null;
24+
this.watchedEditors = new WeakSet();
2525
/**
2626
* [editor description]
2727
* @type {TextEditor}
@@ -79,16 +79,17 @@ module.exports = class DatatipManager {
7979
*/
8080
this.cursorMoveTimer = null;
8181

82+
/**
83+
* [renderer description]
84+
* @type {[type]}
85+
*/
8286
this.renderer = null;
8387
}
8488

8589
/**
8690
* [initialize description]
8791
*/
8892
initialize(renderer) {
89-
this.subscriptions = new CompositeDisposable();
90-
this.providerRegistry = new ProviderRegistry();
91-
this.watchedEditors = new WeakSet();
9293
this.renderer = renderer;
9394

9495
this.subscriptions.add(

lib/main.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,8 @@ module.exports = {
4949
},
5050

5151
consumeMarkdownRenderer(renderer) {
52-
// kick it off after installing the package dependencies
53-
require('atom-package-deps').install('atom-ide-datatip')
54-
.then(() => {
55-
console.log('All dependencies installed, good to go')
56-
this.datatipManager.initialize(renderer);
57-
});
52+
require('atom-package-deps').install('atom-ide-datatip').then(() => {
53+
this.datatipManager.initialize(renderer);
54+
});
5855
}
5956
};

0 commit comments

Comments
 (0)