Skip to content

Commit 172719d

Browse files
committed
fix: rendering of markdown text with additional break in the description
1 parent dba3fa2 commit 172719d

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

lib/datatip-manager.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -303,11 +303,10 @@ module.exports = class DatatipManager {
303303
this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView);
304304
}
305305
else if (datatip.markedStrings.length > 0) {
306-
let htmlString = this.makeHtmlFromMarkedStrings(datatip.markedStrings, editor.getGrammar().name.toLowerCase());
307-
308-
const html = await this.renderer.render(htmlString);
309-
const dataTipView = new DataTipView({ htmlView: html });
310-
this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView);
306+
const htmlString = this.makeHtmlFromMarkedStrings(datatip.markedStrings, editor.getGrammar().name.toLowerCase());
307+
const html = await this.renderer.render(htmlString);
308+
const dataTipView = new DataTipView({ htmlView: html });
309+
this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView);
311310
}
312311
}
313312
}
@@ -328,13 +327,13 @@ module.exports = class DatatipManager {
328327
return markedStrings
329328
.map(string => {
330329
if (string.type === 'markdown') {
331-
return string.value;
330+
return (string.value.length > 0 ? `<p>${string.value}</p>` : null);
332331
} else if (string.type === 'snippet') {
333332
const snippet = string.value.replace(regExpLSPPrefix, '');
334333
return `<pre><code class="${grammarName}">${snippet}</code></pre>`;
335334
}
336335
})
337-
.join('<br>');
336+
.join('');
338337
}
339338

340339
/**

0 commit comments

Comments
 (0)