Skip to content

Commit 0da78d7

Browse files
committed
revert: unrelated and wrong changes
layout, styles and view destroying
1 parent f940370 commit 0da78d7

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

lib/datatip-manager.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,12 @@ module.exports = class DatatipManager {
314314
}
315315
}
316316

317+
/**
318+
* [makeHtmlFromMarkedStrings description]
319+
* @param {[type]} markedStrings [description]
320+
* @param {String} grammarName [description]
321+
* @return {String} [description]
322+
*/
317323
makeHtmlFromMarkedStrings(markedStrings, grammarName) {
318324
const regExpLSPPrefix = /^\((method|property|parameter|alias)\)\W/;
319325

@@ -323,9 +329,7 @@ module.exports = class DatatipManager {
323329
return string.value;
324330
} else if (string.type === 'snippet') {
325331
const snippet = string.value.replace(regExpLSPPrefix, '');
326-
return `<div class="datatip-marked-snippet">
327-
<pre><code class="${grammarName}">${snippet}</code></pre>
328-
</div>`;
332+
return `<pre><code class="${grammarName}">${snippet}</code></pre>`;
329333
}
330334
})
331335
.join('<br>');
@@ -387,6 +391,7 @@ module.exports = class DatatipManager {
387391
new Disposable(() => overlayMarker.destroy()),
388392
new Disposable(() => {
389393
this.editorView.addEventListener("mousemove", this.onMouseMoveEvt);
394+
view.destroy();
390395
}),
391396
new Disposable(() => marker.destroy())
392397
);

styles/atom-ide-datatips-marked.less

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
font-size: var(--editor-font-size);
1212
max-height: 480px;
1313
max-width: 64em;
14-
overflow-x: hidden;
15-
overflow-y: auto;
14+
overflow: auto;
1615
white-space: normal;
1716

1817
// Avoid excess internal padding from markdown blocks.
@@ -24,13 +23,9 @@
2423
margin-bottom: 0;
2524
}
2625

27-
.datatip-marked-snippet {
28-
display: inline-block;
26+
pre {
2927
font-family: var(--editor-font-family);
3028
font-size: var(--editor-font-size);
31-
}
32-
33-
pre {
3429
margin-bottom: 8px;
3530
border-radius: 0;
3631
}

0 commit comments

Comments
 (0)