Skip to content

Commit 0363e9c

Browse files
committed
fix: make mousewheel listener passive
1 parent e3ff865 commit 0363e9c

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

lib/datatip-manager.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,14 @@ export class DataTipManager {
292292
)
293293
}
294294

295+
/**
296+
* handles the mouse wheel event to enable scrolling over long text
297+
* @param evt the mouse wheel event being triggered
298+
*/
299+
onMouseWheel(evt: WheelEvent) {
300+
evt.stopPropagation()
301+
}
302+
295303
/**
296304
* the central command event handler
297305
* @param evt command event
@@ -394,11 +402,6 @@ export class DataTipManager {
394402

395403
const dataTipView = new ViewContainer({ snippet, markdown, className: `datatip-element ${this.glowClass}` })
396404

397-
// TODO move this code to atom-ide-base
398-
dataTipView.element.addEventListener('mousewheel', (e: WheelEvent) => {
399-
e.stopPropagation()
400-
})
401-
402405
this.dataTipMarkerDisposables = this.mountDataTipWithMarker(editor, datatip.range, position, dataTipView)
403406
}
404407
}
@@ -464,6 +467,9 @@ export class DataTipManager {
464467
this.editorView.addEventListener("mousemove", this.onMouseMoveEvt)
465468
})
466469

470+
// TODO move this code to atom-ide-base
471+
view.element.addEventListener("mousewheel", this.onMouseWheel, { passive: true })
472+
467473
disposables.add(
468474
new Disposable(() => {
469475
this.editorView.addEventListener("mousemove", this.onMouseMoveEvt)

0 commit comments

Comments
 (0)