From 51614867e143269fe67dfc41449c670d2fcbf894 Mon Sep 17 00:00:00 2001 From: Mounir Dhahri Date: Mon, 20 Jul 2026 18:47:54 +0200 Subject: [PATCH 1/2] ci(e2e): allow iOS E2E job to run on manual dispatch The job gated on github.event.workflow_run.conclusion == 'success', which is false for workflow_dispatch events (no workflow_run object), so 'Run workflow' started the run but skipped the e2e-tests job. Run the job for non-workflow_run events while keeping the success gate when chained from the build workflow. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/ios-e2e-maestro.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ios-e2e-maestro.yml b/.github/workflows/ios-e2e-maestro.yml index b8fc354023d..0fa00db4654 100644 --- a/.github/workflows/ios-e2e-maestro.yml +++ b/.github/workflows/ios-e2e-maestro.yml @@ -8,7 +8,8 @@ on: workflow_dispatch: # Allows you to trigger the workflow manually from the Actions tab jobs: e2e-tests: - if: ${{ github.event.workflow_run.conclusion == 'success' }} + # Run for manual/scheduled triggers, or only on a successful build when chained from the build workflow. + if: ${{ github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success' }} runs-on: macos-26 # iOS simulators require macOS runners timeout-minutes: 45 strategy: From e0fe4679679b9b902e980612ce638ca018b66ed2 Mon Sep 17 00:00:00 2001 From: Mounir Dhahri Date: Mon, 20 Jul 2026 18:52:18 +0200 Subject: [PATCH 2/2] ci(e2e): allow Android E2E job to run on manual dispatch Same fix as iOS: the job gated on workflow_run.conclusion == 'success' skipped for workflow_dispatch events. Run for non-workflow_run events while keeping the success gate when chained from the build workflow. Co-Authored-By: Claude Opus 4.8 (1M context) Assisted-by: Claude:Opus-4.8 [claude-code] --- .github/workflows/android-e2e-maestro.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/android-e2e-maestro.yml b/.github/workflows/android-e2e-maestro.yml index 2415d287100..c867604961e 100644 --- a/.github/workflows/android-e2e-maestro.yml +++ b/.github/workflows/android-e2e-maestro.yml @@ -9,7 +9,8 @@ on: jobs: e2e-tests: - if: ${{ github.event.workflow_run.conclusion == 'success' }} + # Run for manual/scheduled triggers, or only on a successful build when chained from the build workflow. + if: ${{ github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success' }} runs-on: ubuntu-latest # Use ubuntu-latest for better Android emulator support timeout-minutes: 30 strategy: