Skip to content

Improve readability of progress bar width computation.#1584

Merged
jglogan merged 1 commit into
apple:mainfrom
jglogan:progress-clarify
May 22, 2026
Merged

Improve readability of progress bar width computation.#1584
jglogan merged 1 commit into
apple:mainfrom
jglogan:progress-clarify

Conversation

@jglogan
Copy link
Copy Markdown
Contributor

@jglogan jglogan commented May 22, 2026

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Improves readability by removing complex ternary expressions, breaking computations into clear steps, and uses clearer variable names.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

- Refines bugfix from apple#1547, no functional
  changes.
@jglogan jglogan requested a review from dkovba May 22, 2026 02:27
@github-actions
Copy link
Copy Markdown

Code Coverage

Tier Line Coverage
Unit 33.17%
Integration 19.66%
Combined 52.27%

Copy link
Copy Markdown
Contributor

@dkovba dkovba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jglogan jglogan merged commit caff1e9 into apple:main May 22, 2026
4 checks passed
@jglogan jglogan deleted the progress-clarify branch May 22, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants