Add unit test for #12600 null-guard in forked executions - #12923
Merged
Conversation
gnodet
commented
Aug 29, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
Clean backport of the #12600 NPE fix to maven-3.10.x. No issues found.
Backport observations:
- Production code change (
int→Integer+ null guard + descriptive exception) is identical across all four branches. - Test correctly adapted for 3.10.x APIs:
@Injectfield injection, 3-argexecuteForkedExecutions,Collections.singletonList/emptyListfor Java 8 compatibility. - Test differs from the 3.9.x backport (#12918) only in two comments describing the branch context.
- All CI checks pass: build (macOS, ubuntu, windows), Jenkins, integration tests (JDK 8, 25, 26).
🔀 Backport Status
All maintenance branches are covered:
master— #12911 (MERGED)maven-4.0.x— #12917 (MERGED)maven-3.10.x— #12923 (this PR)maven-3.9.x— #12918 (OPEN)
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
Member
|
@gnodet can you pls rebase? |
Backport of #12911 (merged to master) to maven-3.10.x. Guards against NullPointerException from auto-unboxing when ProjectIndex.getIndices().get() returns null for a project not in the reactor. Throws descriptive LifecycleExecutionException instead. Test adapted for 3.10.x (Java 8 APIs, @Inject field injection). Co-Authored-By: Claude Opus 4.6 <[email protected]>
gnodet
force-pushed
the
backport/12600-to-3.10.x
branch
from
August 31, 2026 01:57
c49ab11 to
897020c
Compare
Member
|
Looks like change was don in #12927 |
gnodet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectIndexnull-guard inMojoExecutor.executeForkedExecutions(issue [maven-4.0.x] MojoExecutor: auto-unbox NPE on missing project index #12600)Test plan
MojoExecutorForkedExecutionTestpasses (2 tests)