Skip to content

Clean up the integration tests of stuff that is never used - #12887

Merged
elharo merged 1 commit into
apache:masterfrom
fridrich:dead-weight
Aug 31, 2026
Merged

Clean up the integration tests of stuff that is never used#12887
elharo merged 1 commit into
apache:masterfrom
fridrich:dead-weight

Conversation

@fridrich

Copy link
Copy Markdown
Contributor

When working on #12871 I realized that there are several unused configuration files and tests some dating from the beginning of this century. So, I made this follow-up commit removing all stuff that is not referenced anywhere. It included even a hardcoded user path on his Mac and several snippets that can mislead someone that is grepping for best practices.

I run the fix through integration tests in embedded and in forked mode, with mimir and without mimir and every time I run them twice, just to be sure there is nothing bombing out on already existing files. The first commit is the actual removal the second commit is the renaming of the tests. So that if one removes test 2 and leaves test 3, there is no gap in the numbering. The diff might be somehow confusing in the renumbering commit, because some tests were bit-to-bit copies, just with different settings.xml.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@fridrich fridrich mentioned this pull request Aug 28, 2026
8 tasks
@fridrich

Copy link
Copy Markdown
Contributor Author

@elharo do you want to review also these ones?

@elharo
elharo requested a review from gnodet August 29, 2026 11:14
elharo
elharo previously requested changes Aug 29, 2026

@elharo elharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I run the fix through integration tests in embedded and in forked mode, with mimir and without mimir and every time I run them twice, just to be sure there is nothing bombing out on already existing files. The first commit is the actual removal the second commit is the renaming of the tests. So that if one removes test 2 and leaves test 3, there is no gap in the numbering. The diff might be somehow confusing in the renumbering commit, because some tests were bit-to-bit copies, just with different settings.xml."

I appreciate the effort, but I think that's making this harder to follow, and I don't think we should rename tests or move files just to keep the numbering intact. That mucks up the history. Can you revert the second commit so this is just about removing files that aren't used and nothing else is touched? Thanks

@elharo
elharo dismissed their stale review August 30, 2026 13:39

comments addressed

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-scoped deletion of 51 unreferenced integration test resource files. Verified each category:

  • profiles.xml files (MNG-2309, MNG-2605, MNG-3259, MNG-3701, MNG-4106): Maven 2 artifacts rendered dead by MNG-4060 (profiles.xml support removed in Maven 3). Tests use settings.xml and POM profiles only.
  • Orphaned test variant directories (mng-3948/test-1, mng-3970/test-1, mng-3983/test-2, mng-4036/legacy): Corresponding test methods were removed previously but resource directories were left behind.
  • Unreferenced settings.xml (MNG-3259, MNG-8572): Tests never pass --settings for these files.

CI is fully green across all platforms and modes.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

@elharo
elharo merged commit f289f00 into apache:master Aug 31, 2026
22 checks passed
@github-actions

Copy link
Copy Markdown

@elharo Please assign appropriate label to PR according to the type of change.

@github-actions github-actions Bot added this to the 4.1.0 milestone Aug 31, 2026
@fridrich

Copy link
Copy Markdown
Contributor Author

I kept the d112029 around if you people change opinion. So that the test numbering is tidy.

@elharo elharo added maintenance skip-changelog Skip this PR from automatically changelog generation labels Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants