Minor: Add interleave tests for List<Decimal128> and List<Timestamp(tz)>#10099
Open
alamb wants to merge 1 commit into
Open
Minor: Add interleave tests for List<Decimal128> and List<Timestamp(tz)>#10099alamb wants to merge 1 commit into
alamb wants to merge 1 commit into
Conversation
alamb
force-pushed
the
interleave-list-decimal-tz-coverage
branch
from
f40bca8 to
9f2dea9
Compare
These exercise interleave over list arrays whose primitive child carries logical type parameters (Decimal precision/scale, Timestamp timezone), asserting the interleaved child preserves the parameterized DataType and correctly carries child-element nulls. Both i32 and i64 offsets covered. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
alamb
force-pushed
the
interleave-list-decimal-tz-coverage
branch
from
9f2dea9 to
e69d41c
Compare
alamb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — test-only coverage improvement.
Rationale for this change
While reviewing #10025 (which adds a primitive-child fast path to
interleave_list), I noticedinterleaveover list arrays had no test for a primitive child that carries logical type parameters —Decimal128/Decimal256precision & scale, or timezone-awareTimestamp.What changes are included in this PR?
Two new tests in
arrow-select/src/interleave.rs, each parameterized overi32/i64offsets:Are these changes tested?
This PR is the tests. They pass on
main, and also guard the fast path added in #10025.Are there any user-facing changes?
No.