Add arrow-flight test coverage for IPC compression#10097
Open
alamb wants to merge 1 commit into
Open
Conversation
Round trips a batch through FlightDataEncoderBuilder with LZ4 and ZSTD IPC body compression enabled, exercising the compressed IpcDataGenerator::encode path that no existing arrow-flight or arrow-ipc test covered. Refactors verify_flight_round_trip to share its encode/decode/assert logic via verify_flight_round_trip_with_options, and enables the arrow-ipc lz4/zstd features as arrow-flight dev-dependencies. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
github-actions
Bot
added
arrow
Rich-T-kid
approved these changes
Jun 9, 2026
Rich-T-kid
left a comment
Rich-T-kid
left a comment
Contributor
There was a problem hiding this comment.
I think these test look good!
Would definitely be nice to have these for future arrow-flight optimizations
Contributor
Author
|
Thank you for the review @Rich-T-kid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up while reviewing #10044.
Rationale for this change
While reviewing #10044 (which reworks the IPC writer's buffer handling), I found that the compressed
IpcDataGenerator::encodepath is not exercised by any test in the repository.What changes are included in this PR?
This PR adds that missing coverage
Are these changes tested?
This PR is test-only.
Are there any user-facing changes?
No.