Add additional coverage for the unquoter (#1498)

Author: bdraco

CHANGES/1498.misc.rst

@@ -0,0 +1 @@
+1496.misc.rst

tests/test_quoting.py

@@ -457,6 +457,14 @@ def test_unquote_plus_to_space_unsafe(unquoter: type[_Unquoter]) -> None:
     assert unquoter(unsafe="+", qs=True)("a+b") == "a+b"
 
 
+def test_unquote_multiple_unsafe(unquoter: type[_Unquoter]) -> None:
+    assert unquoter(unsafe="!@#$")("a!@#$b") == "a%21%40%23%24b"
+
+
+def test_unquote_explict_empty_unsafe(unquoter: type[_Unquoter]) -> None:
+    assert unquoter(unsafe="")("a!@#$b") == "a!@#$b"
+
+
 def test_quote_qs_with_colon(quoter: type[_Quoter]) -> None:
     s = quoter(safe="=+&?/:@", qs=True)("next=http%3A//example.com/")
     assert s == "next=http://example.com/"

yarl/_quoting_c.pyx

@@ -310,6 +310,7 @@ cdef class _Unquoter:
     cdef str _ignore
     cdef bint _has_ignore
     cdef str _unsafe
+    cdef bytes _unsafe_bytes
     cdef Py_ssize_t _unsafe_bytes_len
     cdef const unsigned char * _unsafe_bytes_char
     cdef bint _qs
@@ -322,9 +323,9 @@ cdef class _Unquoter:
         self._has_ignore = bool(self._ignore)
         self._unsafe = unsafe
         # unsafe may only be extended ascii characters (0-255)
-        unsafe_bytes = self._unsafe.encode('ascii')
-        self._unsafe_bytes_len = len(unsafe_bytes)
-        self._unsafe_bytes_char = unsafe_bytes
+        self._unsafe_bytes = self._unsafe.encode('ascii')
+        self._unsafe_bytes_len = len(self._unsafe_bytes)
+        self._unsafe_bytes_char = self._unsafe_bytes
         self._qs = qs
         self._plus = plus
         self._quoter = _Quoter()