0 leaks allowed, skip on ft

Author: bdraco

tests/isolated/multidict_type_leak.py

@@ -1,35 +1,50 @@
-from multidict import MultiDict, istr
+import gc
 import sys
+import sysconfig
+
+from multidict import MultiDict, istr
+
+# sys.getrefcount is not meaningful under the free-threaded build:
+# refcounts are biased per-thread and types may be immortalized, so
+# the simple baseline/after comparison below does not apply.
+FREETHREADED = bool(sysconfig.get_config_var("Py_GIL_DISABLED"))
 
-md = MultiDict([("a", "1"), ("b", "2")])
 
 if __name__ == "__main__":
-    # XXX: Code Coverage misbehaves so do this instead
-    it = iter(md.keys())
-    iter_type = type(it)
-    del it
+    if FREETHREADED:
+        raise SystemExit(0)
+
+    md = MultiDict([("a", "1"), ("b", "2")])
+
+    # Iterator type leak
+    iter_type = type(iter(md.keys()))
+    gc.collect()
     baseline = sys.getrefcount(iter_type)
     for _ in range(1000):
-        it = iter(md.keys())
-        list(it)
-        del it
+        _it = iter(md.keys())
+        list(_it)
+        del _it
+    gc.collect()
     after = sys.getrefcount(iter_type)
+    assert after == baseline, f"iterator type leaked: {after - baseline}"
 
-    # NOTE: On Freethreaded Mode this value can be negative
-    assert (after - baseline) <= 0, "iterator type leaked"
-
-    # Test view type leak
+    # View type leak
     view_type = type(md.keys())
+    gc.collect()
     baseline = sys.getrefcount(view_type)
     for _ in range(1000):
-        v = md.keys()
-        del v
+        _v = md.keys()
+        del _v
+    gc.collect()
     after = sys.getrefcount(view_type)
-    assert (after - baseline) <= 0, "view type leaked"
+    assert after == baseline, f"view type leaked: {after - baseline}"
 
+    # istr type leak
+    gc.collect()
     baseline = sys.getrefcount(istr)
     for _ in range(1000):
-        s = istr("hello")
-        del s
+        _s = istr("hello")
+        del _s
+    gc.collect()
     after = sys.getrefcount(istr)
-    assert (after - baseline) <= 0, "istr type leaked"
+    assert after == baseline, f"istr type leaked: {after - baseline}"