leakfix (#106)

* fix from @gpfei

#105

* add leak test

* add missing req

Author: thehesiod

multidict/_istr.c

@@ -67,6 +67,7 @@ static PyMethodDef istr_methods[] = {
 void istr_dealloc(istrobject *self)
 {
     Py_XDECREF(self->canonical);
+    PyUnicode_Type.tp_dealloc((PyObject*)self);
 }
 
 static PyObject *

requirements-ci.txt

@@ -9,4 +9,5 @@ tox==2.7.0
 sphinxcontrib-newsfeed==0.1.4
 pytest-cov==2.5.1
 pygments==2.2.0
+psutil==5.2.2
 -e .

requirements-dev.txt

@@ -4,3 +4,4 @@ pytest-sugar==0.8.0
 ipython==6.1.0
 pyenchant==1.6.8
 sphinxcontrib-spelling==2.3.0
+psutil==5.2.2

tests/test_istr.py

@@ -1,5 +1,7 @@
 from multidict._multidict import istr
 from multidict._multidict_py import istr as _istr
+import gc
+import psutil
 
 
 class IStrMixin:
@@ -52,6 +54,24 @@ def xtest_eq(self):
 class TestPyIStr(IStrMixin):
     cls = _istr
 
+    @staticmethod
+    def _create_strs():
+        _istr('foobarbaz')
+        istr2 = _istr()
+        _istr(istr2)
+
+    def test_leak(self):
+        gc.collect()
+        p = psutil.Process()
+        info = p.memory_info()
+        for _ in range(10000):
+            self._create_strs()
+
+        gc.collect()
+        info2 = p.memory_info()
+        rss_diff = info2.rss - info.rss
+        assert rss_diff == 0
+
 
 class TestIStr(IStrMixin):
     cls = istr