Implement MultiDict_SetDefault()

Author: asvetlov

multidict/_multilib/capsule.h

@@ -64,6 +64,18 @@ MultiDict_Clear(void *state_, PyObject *self)
     return md_clear((MultiDictObject *)self);
 }
 
+static inline int
+MultiDict_SetDefault(void *state_, PyObject *self, PyObject *key,
+                     PyObject *default_, PyObject **result)
+{
+    mod_state *state = (mod_state *)state_;
+    if (MultiDict_Check(state, self) <= 0) {
+        _invalid_type();
+        return -1;
+    }
+    return md_set_default((MultiDictObject *)self, key, default_, result);
+}
+
 static void
 capsule_free(MultiDict_CAPI *capi)
 {
@@ -91,6 +103,7 @@ new_capsule(mod_state *state)
     capi->MultiDict_New = MultiDict_New;
     capi->MultiDict_Add = MultiDict_Add;
     capi->MultiDict_Clear = MultiDict_Clear;
+    capi->MultiDict_SetDefault = MultiDict_SetDefault;
 
     PyObject *ret =
         PyCapsule_New(capi, MultiDict_CAPSULE_NAME, capsule_destructor);

multidict/multidict_api.h

@@ -30,6 +30,8 @@ typedef struct {
     int (*MultiDict_Add)(void *state, PyObject *self, PyObject *key,
                          PyObject *value);
     int (*MultiDict_Clear)(void *state, PyObject *self);
+    int (*MultiDict_SetDefault)(void *state, PyObject *self, PyObject *key,
+                                PyObject *default_, PyObject **result);
 } MultiDict_CAPI;
 
 #ifndef MULTIDICT_IMPL
@@ -83,6 +85,13 @@ MultiDict_Clear(MultiDict_CAPI *api, PyObject *self)
     return api->MultiDict_Clear(api->state, self);
 }
 
+static inline int
+MultiDict_SetDefault(MultiDict_CAPI *api, PyObject *self, PyObject *key,
+                     PyObject *default_, PyObject **result)
+{
+    return api->MultiDict_SetDefault(api->state, self, key, default_, result);
+}
+
 #endif
 
 #ifdef __cplusplus

setup.py

@@ -11,7 +11,6 @@
     NO_EXTENSIONS = True
 
 CFLAGS = ["-O0", "-g3", "-UNDEBUG"] if DEBUG_BUILD else ["-O3"]
-
 if platform.system() != "Windows":
     CFLAGS.extend(
         [

testcapi/setup.py

@@ -9,6 +9,7 @@
         "testcapi._api",
         ["testcapi/_api.c"],
         include_dirs=multidict.__path__,
+        extra_compile_args=["-O0", "-g3", "-UNDEBUG"],
     ),
 ]
 

testcapi/testcapi/_api.c

@@ -83,6 +83,29 @@ md_clear(PyObject *self, PyObject *const *args, Py_ssize_t nargs)
     Py_RETURN_NONE;
 }
 
+static PyObject *
+md_setdefault(PyObject *self, PyObject *const *args, Py_ssize_t nargs)
+{
+    printf("000000\n");
+    mod_state *state = get_mod_state(self);
+    if (check_nargs("md_setdefault", nargs, 3) < 0) {
+        return NULL;
+    }
+    PyObject *result = NULL;
+    int ret =
+        MultiDict_SetDefault(state->capi, args[0], args[1], args[2], &result);
+    if (ret < 0) {
+        return NULL;
+    }
+    assert(result != NULL);
+    PyObject *val = PyBool_FromLong(ret);
+    if (val == NULL) {
+        Py_CLEAR(result);
+        return NULL;
+    }
+    return PyTuple_Pack(2, result, val);
+}
+
 /* module slots */
 
 static int
@@ -108,6 +131,7 @@ static PyMethodDef module_methods[] = {
     {"md_new", (PyCFunction)md_new, METH_FASTCALL},
     {"md_add", (PyCFunction)md_add, METH_FASTCALL},
     {"md_clear", (PyCFunction)md_clear, METH_FASTCALL},
+    {"md_setdefault", (PyCFunction)md_setdefault, METH_FASTCALL},
     {NULL, NULL} /* sentinel */
 };
 

tests/test_capi.py

@@ -30,3 +30,16 @@ def test_md_clear() -> None:
     md: MultiDictStr = multidict.MultiDict(key="val")
     testcapi.md_clear(md)
     assert len(md) == 0
+
+
+@pytest.mark.parametrize(
+    "key, expected",
+    [
+        pytest.param("key", ("val", True), id="found"),
+        pytest.param("key2", ("default", False), id="notfound"),
+    ],
+)
+def test_md_setdefault(key: str, expected: tuple[str, bool]) -> None:
+    md: MultiDictStr = multidict.MultiDict(key="val")
+    ret = testcapi.md_setdefault(md, key, "default")
+    assert ret == expected