session not saved with web.FileResponse

[Benj1]

I'm not sure if there's a reason to exclude it, but it seems that sessions aren't saved when response is an instance of web.FileResponse.
It gets excluded here when checking the type of the response:

aiohttp-session/aiohttp_session/__init__.py

Lines 204 to 206 in 015dfb1

	if not isinstance(response, (web.Response, web.HTTPException)):
	# likely got websocket or streaming
	return response

[Dreamsorcerer]

Have you tried removing the check and seeing if it works as expected?

[Benj1]

Yes, changing to isinstance(response, (web.Response, web.HTTPException, web.FileResponse)) allows sessions to be set when returning static file responses

[asvetlov]

When I designed aiohttp-session, I made it work with non-streaming responses only.
Theoretically, the library can register on_response_prepare signal to dynamically update the response cookie if needed.
It can allow the processing of all responses, doesn't matter they are streamed or not.
Sorry, I have no idea when I can find time to work on the issue, any contribution is welcome!