Skip to content

Commit 94ba42c

Browse files
authored
Merge pull request #89 from mgorny/setuptools-platform
setup.py: Use platform specifiers instead of extras_require
2 parents 87327d8 + 25cf7e2 commit 94ba42c

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

CHANGES.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGES
22
=======
33

4+
0.5.3 (XXXX-XX-XX)
5+
------------------
6+
7+
- Fix `typing` being installed on Python 3.6.
8+
49
0.5.2 (2017-03-28)
510
------------------
611

appveyor.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ install:
2525
- "powershell ./install_python_and_pip.ps1"
2626
- "SET PATH=%PYTHON%;%PYTHON%\\Scripts;%PATH%"
2727
- "python --version"
28+
- "pip install -U pip setuptools wheel"
2829
- "pip list"
2930
- "pip install -r requirements-dev.txt"
3031
- "python setup.py develop"

setup.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,12 @@ def read_file(filename):
5050
)),
5151
packages=["aiohttp_cors"],
5252
setup_requires=[
53-
# Setuptools fixed environment markers (":python_version < '3.5'")
54-
# in 17.1, and pip in 6.
55-
# TODO: Doesn't work due to
53+
# Environment markers were implemented and stabilized in setuptools
54+
# v20.8.1 (see <http://stackoverflow.com/a/32643122/391865>).
55+
"setuptools>=20.8.1",
56+
# If line above doesn't work, check that you have at least
57+
# setuptools v19.4 (released 2016-01-16):
5658
# <https://github.com/pypa/setuptools/issues/141>
57-
# which were fixed in setuptools 19.4 (released 2016-01-16)
58-
# "pip>=6",
59-
# "setuptools>=17.1",
6059
] + pytest_runner,
6160
tests_require=[
6261
"pytest",
@@ -67,13 +66,8 @@ def read_file(filename):
6766
test_suite="tests",
6867
install_requires=[
6968
"aiohttp>=1.1",
69+
"typing;python_version<'3.5'",
7070
],
71-
extras_require={
72-
# TODO: Rich comparison in environment markers are broken in
73-
# setuptools<17.1 and pip<6.
74-
# ":python_version < '3.5'": ["typing"],
75-
":python_version == '3.4'": ["typing"],
76-
},
7771
license=about["__license__"],
7872
classifiers=[
7973
"License :: OSI Approved :: Apache Software License",

0 commit comments

Comments
 (0)