Fix error when uploading file via api

[trk]

When i try to add image(s) via api getting this error. When i check what i have on $event->arguments(0) its filename of image file.

Fix: Warning: Attempt to read property "id" on string

CustomUploadNames/ProcessCustomUploadNames.module.php

Line 141 in 44c0d1b

$pageid = $event->arguments(0)->id;

$arg = $event->arguments(0);
if (is_string($arg) && strpos($arg, '/') !== false) {
    $pageid = basename(dirname($arg));
} else {
    $pageid = $arg->id;
}

[adrianbj]

Hi @trk - thanks for the report and the fix, but I am honestly not able to reproduce this at the moment. Can you please post the API call you are using that results in $event->arguments(0) being a string with the filename?

[trk]

My usage when i migrate data from old pw instance to new instance via api calls..

/** @var Page $home */
$home = $pages->get(1);
if ($home->hasField('image')) {

    $filenames = [
        '/path/to/file/file-1.jpg',
        '/path/to/file/file-2.jpg',
        '/path/to/file/file-3.jpg',
    ];

    $imageField = $home->getUnformatted('image');
    // if we have a ComboValue
    foreach ($filenames as $filename) {
        if (!file_exists($filename)) {
            continue;
        }
        $imageField->add($filename);
        $last = $imageField->last();
        $last->description = 'This is a test image.';
        $home->save();
    }
}

[trk]

@adrianbj Also there is a problem about getting page id and page info when we are using image field inside ComboField. Did you try your module with a combo field ?

[adrianbj]

I can't replicate the issue with your API call but I do wonder about the name of the image field being singular: image vs images even though you are adding multiple images to it. Not sure if that is maybe involved?

As for Combo field - I haven't tried the module with it. I love the idea of the Combo field, but don't trust it for anything other than simple text fields because experience has taught me that at some point I'll want a feature for a subfield that isn't supported.

[trk]

I think Pageimage and Pageimages fields are same. When you get formatted version you have limitation of Pageimage. When you get it unformatter you have a Pageimages instance. After i apply my fix i move data between 2 instance. 1000+ most have image field, 1 template has images fields. Inside repeaters and repeater matrix fields i follow same methods and moved all data to new instance. I have only problem with Combo field but i don't use it common cases. For seo things with seo image..

I will retest it, i will let you know the result..