Skip to content

[qgroundcontrol] not compiling because of Werror #273

Description

@amstan

The new compilers on arch seem to trigger -Werror=template-id-cdtor on qgroundcontrol.

compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/shapelib/safileio.c
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/xz-embedded/linux/lib/xz/xz_crc32.c
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/xz-embedded/linux/lib/xz/xz_crc64.c
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/xz-embedded/linux/lib/xz/xz_dec_lzma2.c
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/xz-embedded/linux/lib/xz/xz_dec_stream.c
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/qmdnsengine/src/src/abstractserver.cpp
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/qmdnsengine/src/src/bitmap.cpp
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/qmdnsengine/src/src/browser.cpp
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/qmdnsengine/src/src/cache.cpp
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/qmdnsengine/src/src/dns.cpp
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/qmdnsengine/src/src/hostname.cpp
compiling /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/libs/qmdnsengine/src/src/mdns.cpp
In file included from /usr/include/qt/QtCore/qfuture.h:45,
                 from /usr/include/qt/QtCore/QtCore:97,
                 from /usr/include/qt/QtQml/QtQmlDepends:3,
                 from /usr/include/qt/QtQml/QtQml:3,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/MissionManager/MissionItem.h:16,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/MissionManager/PlanManager.h:16,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/MissionManager/MissionManager.h:12,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/Vehicle/Vehicle.h:44,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/Joystick/Joystick.h:20,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/Settings/SettingsGroup.h:14,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/Settings/FlightMapSettings.h:12,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/QGCApplication.h:26,
                 from /home/alex/.cache/pikaur/build/qgroundcontrol/src/qgroundcontrol-4.4.0/src/QtLocationPlugin/QGCMapEngine.cpp:18:
/usr/include/qt/QtCore/qfutureinterface.h:284:37: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
  284 |     explicit QFutureInterface<void>(State initialState = NoState)
      |                                     ^~~~~
/usr/include/qt/QtCore/qfutureinterface.h:284:37: note: remove the ‘< >’

I'm sure this new error is very helpful for developers (especially since it came after the code was written and it seemed to have been fine until now), but it has no business being considered in a PKGBUILD.

I recommend you filter out any Werror from the project build scripts in your PKGBUILDs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions