Skip to content

Cosmetics batch from audit-series reviews #379

Description

@andrewklingelhofer

Small non-blocking findings from the #365#372 review pass:

  1. src/tracker/jira.ts:67-71 — spurious "hit pagination cap" warning when the final page lands exactly on 200 issues (cappedOut set even though isLast was true).
  2. src/unified-spawner.ts:654 — if salvage push fails while a PR exists, the caller still reports "saved as draft PR: " even though the newest commits didn't land (logged via logTaskError; misleading console output only).
  3. src/runner/generic.ts:62 — reads .critter-report.md without try/catch (same IO race the codex fix addressed; fails loudly into phase failure, so safe but inconsistent).
  4. src/runner/review.ts:155 — merge-confirmation gate doesn't check prStateResult.code; a gh outage surfaces as the generic "Could not determine review outcome" rather than something diagnostic (fail-safe direction; retry recovers).
  5. CLAUDE.md:79 — still lists issue-page, log-page in the dashboard description; those files were deleted in chore: remove dead code identified by audit #366.
  6. critters clean --panes refusal prints to stderr but exits 0, so scripts can't distinguish refusal from success.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions