[Issue] Selfbot icon cant be clicked

[Eaaz93]

Issue type *

Bug

Server/AzerothCore version

No response

Description *

Account level is 3
playerbots.conf: AiPlayerbot.SelfBotLevel = 1


I can't click the Selfbot icon; it stays gray. It works when I enter the command ".playerbots bot self" manually. However, the "bot" doesn't appear in the list under "Playerbot Main Menu" either.

Steps to reproduce

Login
Open Playerbot Main Menu
Click Selfbot

Expected behavior *

The Selfbot should be activated, and the playerbot should appear in the playerbot main menu.

Actual behavior / Errors

No response

Crashlog / Gist link (optional)

No response

Screenshots

Pre-submission checklist *

• I searched for existing issues that match mine.
• I tested with the minimum set of addons/changes.
• I provided reproduction steps and/or relevant logs.

Additional context

No response

[Raz0r1337]

Self bot is only clickable on the red roster, if you at another the icon can appear, but it's not clickable. Otherwise it has to be configured first in the playerbot.conf of the server. If Self bot is forbidden for normal users there you won't be able to click on it anyways. Per default it's set that only a GM can use the self bot feature. But I think you should switch to the red roster and you should be fine to go with self bot.

I tested it now and I was able to toggle the self bot feature during the red roster of MB.

If that don't work look on the bridge if you have the newest version installed and if MB is the newest version.

[Eaaz93]

Excuse me, but what is the Red Roster?

[Raz0r1337]

If you click on the scroll icon, there opens a vertical bar. On top of this bar should be a roster button. The color of these button tells you on which roster you are. Geen = Actually, Red = Guild, Blue = friendliest.

On the red roster the self bot icon is definitely clickable. If the server is configured well.

I hope this is understandable. 😅

[Eaaz93]

So I selected the red roster, my account is level 3 (i.e., GM), and SelfBot is set to 1 in the config. Unfortunately, I still can't click the SelfBot button... Do you have any idea what might be causing this? The command ".playerbots bot self" works.

[Raz0r1337]

Then I have no idea, but Wishmaster will look at this I think.

[Zoidwaffle]

I appear to have the same issue as described by @Eaaz93.

Using commit ef341a4 (the latest at the moment) and for the bridge fba3d24 (also latest at the moment).

Edit: I also tested with all addons, except Multibot, disabled. No difference for this issue.

[Wishmaster117]

Self bot is only clickable on the red roster, if you at another the icon can appear, but it's not clickable. Otherwise it has to be configured first in the playerbot.conf of the server. If Self bot is forbidden for normal users there you won't be able to click on it anyways. Per default it's set that only a GM can use the self bot feature. But I think you should switch to the red roster and you should be fine to go with self bot.

I tested it now and I was able to toggle the self bot feature during the red roster of MB.

If that don't work look on the bridge if you have the newest version installed and if MB is the newest version.

You think i add a condition to hide it if the player are not in red roster?

[Raz0r1337]

Idk, but the self bot Button is only visible in the Red roster. 🤷

[Raz0r1337]

But I have to take back what I said about being able to activate the self-bot. I don't know why it's not working anymore. 🤷

[Wishmaster117]

Compiling server right now with latest updates i try that, as the res roster is the default i haven' noticed that he desapear when i change roster :D
Need to grab some motivation to finish the bridge omg...

[Raz0r1337]

It's okay that the self-bot button is only in the red roster; that's always been the case with MB. 😉

[Wishmaster117]

Strange i received this mail:
@Sakhwoow
left a comment
(Wishmaster117/MultiBot-Chatless#33)
Problem with selfbot button
In the new bridge-path (SyncBridgeRosterToPlayers, MultiBot.lua:1431) selfbot button is created, but the click handler is not assigned:

-- Normal bots - get BindUnitToggleHandlers (line 1453)
if MultiBot.BindUnitToggleHandlers then
MultiBot.BindUnitToggleHandlers(button, ...) -- ← doLeft/doRight are assigned
end

-- Selfbot — only created and disabled, without doLeft/doRight
local selfButton = MultiBot.addSelf(playerClass, playerName)
if selfButton and selfButton.setDisable then
selfButton.setDisable() -- ← doLeft is not assigned anywhere!
end

Even if BindUnitToggleHandlers was called, it would assign .playerbot bot add PlayerName, which is incorrect for a selfbot. The correct command is .playerbot bot self.

In the old SAY-path (MultiBotHandler.lua:1607), the handler was assigned correctly:

tPlayer.doLeft = function(pButton)
SendChatMessage(".playerbot bot self", "SAY")
MultiBot.OnOffSwitch(pButton)
end

Fix
In MultiBot.lua, add the handler after addSelf:

local selfButton = MultiBot.addSelf(playerClass, playerName)
if selfButton then
if selfButton.setDisable then selfButton.setDisable() end
selfButton.doLeft = function(pButton)
SendChatMessage(".playerbot bot self", "SAY")
MultiBot.OnOffSwitch(pButton)
end
end

One line of code and the button works. The problem is purely in the client addon, the server part has nothing to do with it.

But don't see this comment, if you solved the issue, can you make a PR please?

[Zoidwaffle]

I took the liberty of creating the PR, I cannot take any credit for the fix. It does appear to work just fine for me when testing :-)