Merge pull request #20 from Wikodit/fix/wik-webservice-hpa-replicas

fix(wik-webservice): omit replicas in deployment if HPA is enabled

Author: bennurize

.github/workflows/lint-test.yaml

@@ -208,5 +208,8 @@ jobs:
         with:
           cluster_name: chart-testing
 
+      - name: Install Gateway API CRDs
+        run: kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v1.5.0/standard-install.yaml
+
       - name: Run chart-testing (install)
         run: ct install --config ct.yaml

CONTRIBUTING.md

@@ -105,6 +105,8 @@ maintainers:
     email: [email protected]
   - name: Jeremy Trufier
     email: [email protected]
+  - name: Yaniss Loisel
+    email: [email protected]
 keywords:
   - wikodit
   - <chart-specific-keywords>

charts/wik-webservice/Chart.yaml

@@ -14,6 +14,8 @@ maintainers:
     email: [email protected]
   - name: Jeremy Trufier
     email: [email protected]
+  - name: Yaniss Loisel
+    email: [email protected]
 keywords:
   - wikodit
   - webservice

charts/wik-webservice/README.md

@@ -1037,3 +1037,4 @@ webservice:
 | Wikodit |  | <https://github.com/wikodit> |
 | Anthony Domingue | <[email protected]> |  |
 | Jeremy Trufier | <[email protected]> |  |
+| Yaniss Loisel | <[email protected]> |  |

charts/wik-webservice/templates/deployment.yaml

@@ -14,7 +14,11 @@ metadata:
     pod-security.kubernetes.io/warn: {{ .Values.podSecurityStandard.level }}
 {{ end }}
 spec:
+  {{- /* When the HPA owns scaling, omitting replicas prevents every (ArgoCD/helm) apply
+    from resetting the HPA-managed count (scale-up would be reverted on each sync) */}}
+  {{- if not .Values.horizontalPodAutoscaler.enabled }}
   replicas: {{ .Values.webservice.replicas }}
+  {{- end }}
   revisionHistoryLimit: {{ .Values.webservice.revisionHistoryLimit }}
   selector:
     matchLabels: