From 8e4bdeaeef69c72ffcbab5983aa552189f5f4b5c Mon Sep 17 00:00:00 2001 From: Rage Lopez Date: Mon, 27 Jul 2026 09:07:50 -0500 Subject: [PATCH] docs: record Kaoto forms merge outcome --- README.md | 1 + docs/UPSTREAM_CONTRIBUTION_LEDGER.md | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 31c9c54..de1c08b 100644 --- a/README.md +++ b/README.md @@ -170,6 +170,7 @@ The lifecycle gate is calibrated against observed upstream outcomes as well as s - [Hermes Agent #69696](https://github.com/NousResearch/hermes-agent/pull/69696) is an open, maintainer-authored broader solution that explicitly subsumes and credits my still-open [#43834](https://github.com/NousResearch/hermes-agent/pull/43834) for independently mapping the desktop login-shell `PATH` bug family. Neither PR is counted as a merge. The event demonstrates the difference between an aging point patch and a diagnosis that survives into a better system-wide design. - [Karakeep #2864](https://github.com/karakeep-app/karakeep/pull/2864) merged on July 26, 2026 and is scheduled for the next release. It was a one-line, component-local overflow fix for tall screenshot previews, validated by the project's format, lint, typecheck, test, diff-check, and pre-commit gates. The long review queue did not broaden the patch or produce a requested technical rework. +- [Kaoto forms #104](https://github.com/KaotoIO/forms/pull/104) merged into `1.x` on July 27, 2026 after project-member approval. The two-file fix traced a downstream Kaoto empty-state report to the owning shared forms package, removed an impossible “switch to All” instruction when `All` was already selected, and added focused regression coverage. The review produced no requested technical rework. These are author-run contribution outcomes, not maintainer endorsements of PCF or proof of product validity. The detailed evidence and retained gates are recorded in the [Upstream Contribution Learning Ledger](docs/UPSTREAM_CONTRIBUTION_LEDGER.md). diff --git a/docs/UPSTREAM_CONTRIBUTION_LEDGER.md b/docs/UPSTREAM_CONTRIBUTION_LEDGER.md index 3bf2894..34413a9 100644 --- a/docs/UPSTREAM_CONTRIBUTION_LEDGER.md +++ b/docs/UPSTREAM_CONTRIBUTION_LEDGER.md @@ -118,15 +118,16 @@ Before any public PR or comment, the contribution lane must pass these checks: - Gate retained: for bucket issues, choose exactly one current warning class, prove it on current `staging`, leave unrelated warning classes for separate PRs, and avoid claiming the whole bucket is closed. - Follow-up: after merge, left one short thank-you/provenance comment explaining that PCF helped keep the Amber contribution narrow, check overlap, and verify generated output before opening. -### 2026-06-11 - Open PR - `KaotoIO/forms#104` +### 2026-07-27 - Accepted - `KaotoIO/forms#104` - PR: - Related issue: -- Outcome: opened as a narrow bugfix PR against the `1.x` forms branch; initial GitHub readback reported it as open, mergeable, and not draft. CodeRabbit review was pending at closeout. +- Outcome: merged into `1.x` at `2026-07-27T13:58:06Z` after project-member approval; the direct VrtxOmega contribution landed as merge commit `f76fee10dfd2cf84d1c209be41e8f9203f8c8339`. - What was wanted: a `bug` + `good first issue` + `help wanted` empty-state copy fix where the form already on the `All` tab should not tell the user to switch to `All`. - What changed: `NoFieldFound` now keeps the `Switch to All tab` action for filtered `Required` / `Modified` tabs, but shows a plain no-results message when `All` is already selected. -- Evidence: `KaotoIO/kaoto#3283` was already merged and intentionally scoped to adding REST DSL search, while `#3281` was opened separately for this shared forms-library message. `@kaoto/forms@1.7.1` and `1.7.2` had identical `NoFieldFound` output, so the fix belonged in `KaotoIO/forms` rather than a Kaoto app dependency bump. +- Evidence: `KaotoIO/kaoto#3283` was already merged and intentionally scoped to adding REST DSL search, while `#3281` was opened separately for this shared forms-library message. `@kaoto/forms@1.7.1` and `1.7.2` had identical `NoFieldFound` output, so the fix belonged in `KaotoIO/forms` rather than a Kaoto app dependency bump. The merged diff remained limited to `NoFieldFound.tsx` and its focused regression test; CodeRabbit generated no actionable review comments. - Gate retained: when a downstream app issue points at a shared library component, verify the library source/release branch first and open the PR in the owning repo/release line instead of patching around the symptom in the app. +- Follow-up: after merge, left one short thank-you/provenance comment explaining that the contribution workflow helped trace the report to the shared package and keep the patch limited to the All-tab empty state. ### 2026-06-11 - Open PR - `StingraySoftware/stingray#978`