Skip to content

Release 4.4.0 rc1#1761

Merged
jamesmisson merged 6 commits into
UniversalViewer:release-4.4.0from
jamesmisson:release-4.4.0-rc1
May 22, 2026
Merged

Release 4.4.0 rc1#1761
jamesmisson merged 6 commits into
UniversalViewer:release-4.4.0from
jamesmisson:release-4.4.0-rc1

Conversation

@jamesmisson
Copy link
Copy Markdown
Contributor

@jamesmisson jamesmisson commented May 18, 2026

4.4.0 shows a layers button on the OSD panel for manifests with choice on the canvas, allowing users to select which choice to view. To access the layers button, select a manifest from the 'Choices on a canvas' section of the manifest examples. Choice is not yet supported on mobile.

Details can be found in the feature PR:
#1748

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
universalviewer Ready Ready Preview, Comment May 22, 2026 10:37am
universalviewer.dev Ready Ready Preview, Comment May 22, 2026 10:37am

Request Review

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

@jamesmisson is attempting to deploy a commit to the Universal Viewer Team on Vercel.

A member of the Team first needs to authorize it.

@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

In the “Page Choice Combination” manifest, when I click the “Single Page View”:

  • Images 1 to 3 show no download options available.
  • Image 4 has download options available.
  • Images 5 and 6 also have no download options available, but I need to refresh the page first for the pop-up message to appear.
  • The last image, Image 7, has download options available.

This behaviour only happens in “Single Page View.” Once I switch to “Two Page View,” I need to refresh the page again before the download pop-up message appears.
Though this is not a blocker moving forward, I just wanted to confirm whether this is the expected behavior for the download button in this manifest.

Screen.Recording.2026-05-18.121630.mp4

@demiankatz
Copy link
Copy Markdown
Contributor

@LanieOkorodudu, does the dev branch show the same behavior, or is this issue unique to the RC?

@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

@LanieOkorodudu, does the dev branch show the same behavior, or is this issue unique to the RC?

I just tested this RC

@demiankatz
Copy link
Copy Markdown
Contributor

Maybe worth testing the last release at uv-v4.netlify.app to determine whether this is a side effect of recent changes or an existing behavior. If it's existing and a problem, we can open an issue; otherwise, maybe work is needed sooner.

@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

LanieOkorodudu commented May 18, 2026

Maybe worth testing the last release at uv-v4.netlify.app to determine whether this is a side effect of recent changes or an existing behavior. If it's existing and a problem, we can open an issue; otherwise, maybe work is needed sooner.

same behaviour on the dev side. I just tested now.
I just tested it on the Netlify app, and it seems like all the images have download options available.

@demiankatz
Copy link
Copy Markdown
Contributor

The dev branch is the same code as the RC. The Netlify app is the main branch which should contain release 4.3... so it seems like a problem has been introduced by recent changes.

@jamesmisson
Copy link
Copy Markdown
Contributor Author

Hi @LanieOkorodudu , good spot, the download dialogue doesn't work for canvases with choice. I'll have a look into it.

@jamesmisson
Copy link
Copy Markdown
Contributor Author

Hi @demiankatz and @LanieOkorodudu , the bug in the download dialogue is complicated. Fixing it would need some planning and requirements around how best to enable choice downloads (e.g. do we want all choice downloads to be displayed? Or just the currently displayed one? And making this work for the 2-up download selection too...). I suggest we just disable downloads for choice in this release, which is simple enough to do and would stop it from crashing. I think we've talked about the need for the download dialogue to be rewritten so supporting choice download could be an issue for that bit of work.

@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

Hi @demiankatz and @LanieOkorodudu , the bug in the download dialogue is complicated. Fixing it would need some planning and requirements around how best to enable choice downloads (e.g. do we want all choice downloads to be displayed? Or just the currently displayed one? And making this work for the 2-up download selection too...). I suggest we just disable downloads for choice in this release, which is simple enough to do and would stop it from crashing. I think we've talked about the need for the download dialogue to be rewritten so supporting choice download could be an issue for that bit of work.

If fixing the download dialog is going to take more time or turn out to be more complicated, I agree with you just disabling the download option for this release. Might also be worth creating a separate issue so we don’t forget to come back and address it later, if that’s the right approach.

@demiankatz
Copy link
Copy Markdown
Contributor

@jamesmisson, are you suggesting that we always show the "main" choice in the download dialog, to mirror existing behavior, rather than reflect whatever choice is active? If so, I think that sounds reasonable until we can come up with something more sophisticated. But if you're saying that opening the choice menu will inevitably cause the download options to change or be disabled, that seems likely to cause confusion, and we might at least want to come up with a way to show a warning in the menu to let people know they need to turn off layers to download things.

demiankatz
demiankatz previously approved these changes May 20, 2026
Copy link
Copy Markdown
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this RC so it can be merged, to allow the creation of RC2 (as discussed at steering group today).

@jamesmisson
Copy link
Copy Markdown
Contributor Author

Hi @demiankatz and @LanieOkorodudu , I've opened a PR against the release candidate branch (on my own fork), here: jamesmisson#1

I will hold off on merging this into a new release candidate, as I'll add mobile support for the choice feature in rc-2 too.

Fix download dialogue bug in 4.4.0-rc1
@LanieOkorodudu
Copy link
Copy Markdown
Collaborator

Hi @demiankatz and @LanieOkorodudu , I've opened a PR against the release candidate branch (on my own fork), here: jamesmisson#1

I will hold off on merging this into a new release candidate, as I'll add mobile support for the choice feature in rc-2 too.

All good and is much better now @jamesmisson, Thanks

@jamesmisson jamesmisson merged commit be5c5b6 into UniversalViewer:release-4.4.0 May 22, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants