chore: update posthog to 2.5.0#39
Closed
T0ha wants to merge 1 commit into
Closed
Conversation
Attempted to update to the latest posthog release (2.11.0), but every version from 2.6.0 onward fails to compile on this project's pinned Erlang/OTP 28 toolchain: source_code_exclude_patterns stores compiled Regex literals in a module attribute that's referenced from a function, which OTP 28 can no longer inline (compiled regexes are now references, not escapable terms). Pinning to ~> 2.5.0, the last release before that feature landed, until upstream fixes it. Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
Review: chore: update posthog to 2.5.0 This is a small, well-scoped dependency bump. Overall it looks solid, with good investigation and documentation of the OTP 28 incompatibility rather than blindly bumping to latest. Code quality / best practices:
Potential bugs / issues:
Performance considerations:
Security concerns:
Test coverage:
Nit:
Nice, careful root-cause investigation for why the full 2.11.0 bump was not possible, that context will save the next person real time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
posthogdependency from 2.4.0 toward the latest release.source_code_exclude_patternswith compiledRegexliterals stored in a module attribute (PostHog.Config) that's referenced inside a function body. That pattern fails to compile on Erlang/OTP 28 (this repo's pinned toolchain per.tool-versions:erlang 28.0.2,elixir 1.18.4-otp-28) because OTP 28 changed compiled regexes to be represented as references, which can no longer be inlined into function bytecode. Reproduced with a minimal standalone snippet, confirmed against posthog's own CHANGELOG (feature introduced in 2.6.0, still present in 2.11.0), and confirmed there's no existing upstream issue/fix yet.{:posthog, "~> 2.5.0"}(was"~> 2.0") — the last release before the incompatible feature landed — with a comment explaining why, so it isn't silently re-bumped into the broken range. Should be revisited once upstream fixes the OTP 28 incompatibility.PostHog.capture/2(lib/bodhi/tg_webhook_handler.ex,lib/bodhi/periodic_messages.ex), unaffected by any 2.4.0→2.5.0 changes.mix.lockalso picked up a few shared transitive dependency bumps (castore,decimal,ecto,finch,hpax,jason,mint,plug,req,telemetry) — all within existingmix.exsversion constraints, resolver-driven from unlocking posthog's dependency subtree.Verification
mix compile— clean, no new warnings (one pre-existing warning intg_webhook_handler.exconfirmed present onmaintoo, unrelated to this change)mix dialyzer— 0 errorsmix format— no changes neededmix test/iex -S mixboot — could not run locally: this sandbox has no PostgreSQL/Docker and no root access to install either. CI'scode-checks.ymlprovisions Postgres viadocker composeand runs the full suite — please confirm it's green before merging.Test plan
mix testpasses (requires Postgres, unavailable in the dev sandbox that authored this PR)iex -S mix/ boot check passes