Merge pull request #424 from SANDAG/remove_bike_skims

Remove unused bike skims in 2zoneSkim

Author: bhargavasana

src/asim/scripts/resident/2zoneSkim.py

@@ -13,7 +13,6 @@
 class SkimParameters:
     """Configuration parameters for skim generation read from YAML file"""
     max_maz_maz_walk_dist_feet: int
-    max_maz_maz_bike_dist_feet: int
     max_maz_local_bus_stop_walk_dist_feet: int
     max_maz_premium_transit_stop_walk_dist_feet: int
     walk_speed_mph: float
@@ -25,7 +24,6 @@ def from_yaml(cls, yaml_data: dict) -> 'SkimParameters':
         mmms = yaml_data['mmms']
         return cls(
             max_maz_maz_walk_dist_feet=int(mmms['max_maz_maz_walk_dist_feet']),
-            max_maz_maz_bike_dist_feet=int(mmms['max_maz_maz_bike_dist_feet']),
             max_maz_local_bus_stop_walk_dist_feet=int(mmms['max_maz_local_bus_stop_walk_dist_feet']),
             max_maz_premium_transit_stop_walk_dist_feet=int(mmms['max_maz_premium_transit_stop_walk_dist_feet']),
             walk_speed_mph=float(mmms['walk_speed_mph']),
@@ -305,7 +303,7 @@ def process_transit_stops(cls, stops: pd.DataFrame, network: pdna.Network, nodes
         return stops
 
 class SkimGenerator:
-    """Main class for generating walk, bike, and stop skims"""
+    """Main class for generating walk and stop skims"""
 
     def __init__(self, network_builder: NetworkBuilder, params: SkimParameters, output_path: str):
         self.network_builder = network_builder
@@ -327,13 +325,6 @@ def generate_maz_maz_walk_skim(self) -> pd.DataFrame:
         walk_skim = self._convert_columns_to_type(walk_skim, {'OMAZ': 'uint16', 'DMAZ': 'uint16', 'i': 'uint16', 'j': 'uint16'})
         return walk_skim
 
-    def generate_maz_maz_bike_skim(self) -> pd.DataFrame:
-        """Generate MAZ to MAZ bike skims"""
-        maz_pairs = self._create_maz_pairs(self.net_centroids)
-        bike_skim = self._get_bike_distances(maz_pairs, self.params.max_maz_maz_bike_dist_feet)
-        bike_skim = self._convert_columns_to_type(bike_skim, {'OMAZ': 'uint16', 'DMAZ': 'uint16'})
-        return bike_skim
-        
     def generate_maz_stop_walk_skim(self) -> pd.DataFrame:
         """Generate MAZ to stop walk skims"""
         maz_stop_pairs, maz_stop_output = self._create_maz_stop_pairs(self.net_centroids, self.stops)
@@ -424,18 +415,6 @@ def _get_walk_distances(self, pairs: pd.DataFrame, max_dist: float) -> pd.DataFr
 
         return result
 
-    def _get_bike_distances(self, pairs: pd.DataFrame, max_dist: float) -> pd.DataFrame:
-        """Process bike distances between MAZ pairs"""
-        filtered = pairs[pairs["DISTWALK"] <= max_dist / 5280.0].copy()
-        filtered["DISTBIKE"] = self.network_builder.network.shortest_path_lengths(
-            filtered["OMAZ_NODE"].values, filtered["DMAZ_NODE"].values)
-        result = filtered[filtered["DISTBIKE"] <= max_dist / 5280.0]
-
-        # Add missing MAZs
-        result = self._add_missing_mazs(self.net_centroids, result, pairs, 'DISTBIKE')
-        
-        return result
-    
     def _get_stop_distances(self, pairs: pd.DataFrame) -> pd.DataFrame:
         """Process stop distances between MAZ pairs"""
         filtered = pairs[(pairs["DISTANCE"] <= self.params.max_maz_local_bus_stop_walk_dist_feet / 5280.0) & (pairs['MODE'] == 'L') | 
@@ -565,10 +544,6 @@ def main(path: str):
     walk_skim = skim_generator.generate_maz_maz_walk_skim()
     walk_skim.to_csv(os.path.join(output_path, config['mmms']['maz_maz_walk_output']), index=False)
 
-    print(f"{datetime.now().strftime('%H:%M:%S')} Generating MAZ-MAZ bike skims...")
-    bike_skim = skim_generator.generate_maz_maz_bike_skim()
-    bike_skim.to_csv(os.path.join(output_path, config['mmms']['maz_maz_bike_output']), index=False)
-    
     print(f"{datetime.now().strftime('%H:%M:%S')} Generating MAZ-stop walk skims...")
     stop_skim = skim_generator.generate_maz_stop_walk_skim()
     stop_skim.to_csv(os.path.join(output_path, "maz_stop_walk.csv"), index=False)