Addressing Comments.

1. Add comments related to documentation for check-asan target.
2. Ensure that check-asan target should only be executed for smoke-asan
   tests.

Author: ampandey-AMD

test/smoke-asan/Makefile

@@ -23,13 +23,15 @@ run run_obin run_sbin run_llbin clean clean_log llbin sbin obin:
 	  $(MAKE) -C $$test_dir $@; \
 	done
 
-check:
-	 @for test_dir in $(TESTS_DIR); do \
-          echo $$nnn; \
-          test_name=`grep "TESTNAME *=" $$test_dir/Makefile | sed "s/.*= *//"`; \
-          echo "TEST_DIR: $$test_dir\tTEST_NAME: $$test_name\tMAKE: $(MAKE) -C $$test_dir $@"; \
-          $(MAKE) -C $$test_dir $@; \
-        done
+check: check-asan
+
+check-asan:
+	@for test_dir in $(TESTS_DIR); do \
+	  echo $$nnn; \
+	  test_name=`grep "TESTNAME *=" $$test_dir/Makefile | sed "s/.*= *//"`; \
+	  echo "TEST_DIR: $$test_dir\tTEST_NAME: $$test_name\tMAKE: $(MAKE) -C $$test_dir $@"; \
+	  $(MAKE) -C $$test_dir $@; \
+	done
 
 .ll .ll.s .ll.o .s .s.o .o:
 	@for test_dir in $(TESTS_DIR); do \

test/smoke/Makefile.rules

@@ -128,51 +128,69 @@ endif
 check-asan: $(TESTNAME)
 ifneq (,$(findstring $(GPU_W_FEATURES),$(SUPPORTED)))
 ifeq (,$(findstring $(GPU_W_FEATURES),$(UNSUPPORTED)))
-       path=`pwd`; \
-       base=`basename $$path`; \
-       ( \
-    flock -e 9 && echo  "" >> ../check-smoke-asan.txt; \
-    declare -A CmdStatus; \
-    pipeline="$(RUNENV) $(SMOKE_TIMEOUT) $(RUNPROF) $(RUNPROF_FLAGS) $(CHECK_COMMAND) > /dev/null 2>&1"; \
-    $(RUNENV) $(SMOKE_TIMEOUT) $(RUNPROF) $(RUNPROF_FLAGS) $(CHECK_COMMAND) > /dev/null 2>&1; \
-    pstat=($${PIPESTATUS[@]}); \
-    function GetPipedCmdStatus() { \
-      Cmd="$$2"; \
-      CmdRunIndex="$$3"; \
-      CmdRunIndexList=($$(echo $$1 | awk -F'|' '{for(i=1;i<=NF;i++) {gsub(/^[ \t]+|[ \t]+$$/, "", $$i); print $$i}}' | awk -v Cmd_Pattern="$$Cmd " '$$0~Cmd_Pattern {print NR}')); \
-      for CmdIndex in "$${CmdRunIndexList[@]}"; do \
-        if [ -v CmdStatus["$$Cmd"] ]; then \
-           ArrString=$${CmdStatus["$$Cmd"]}; \
-           ArrString+=",$${pstat[$$CmdIndex-1]}"; \
-           CmdStatus["$$Cmd"]=$${ArrString}; \
-        else \
-           NewArrString=$${pstat[$$CmdIndex-1]}; \
-           CmdStatus["$$Cmd"]=$${NewArrString}; \
-        fi; \
-      done; \
-      if [ -v CmdStatus[$$Cmd] ] && [ $$CmdRunIndex -gt 0 ];then \
-         IFS=',' read -ra CmdStatusList <<< "$${CmdStatus[$$Cmd]}"; \
-         return $${CmdStatusList["$$CmdRunIndex"-1]}; \
-      fi; \
-    }; \
-    GetPipedCmdStatus "$$pipeline" "$(TESTNAME)" "1"; \
-    test_status=$$?; \
-    GetPipedCmdStatus "$$pipeline" "FileCheck" "1"; \
-    filecheck_status=$$?; \
-    echo "$$test_status" > TEST_STATUS; \
-    echo "$$filecheck_status" > FILECHECK_STATUS; \
-    echo $$base $$test_num return code: $$test_status >> ../check-smoke-asan.txt; \
-    echo  "" >> ../check-smoke-asan.txt; \
-    if [ $$filecheck_status -eq 0 ]; then echo $$base $$test_num >> ../passing-tests.txt; \
-                                     else echo $$base $$test_num >> ../failing-tests.txt; fi; \
-       )9>../lockfile;
+	path=`pwd`; \
+	base=`basename $$path`; \
+	( \
+	  flock -e 9 && echo  "" >> ../check-smoke-asan.txt; \
+	  # CmdStatus: Associative Container which keeps track of execution status of any command in the pipeline. \
+	  declare -A CmdStatus; \
+	  # GetPipedCmdStatus: Function which on demand populates the CmdStatus container with execution status values of each command executing in a given input pipeline. \
+	  # param_1: pipeline as string. \
+	  # param_2: pipestatus computed from PIPESTATUS as array. \
+	  # param_3: Cmd Name as string. \
+	  # param_4: CmdRunIndex of Cmd as positive integer. \
+	  function GetPipedCmdStatus() { \
+	  # pstat: Piped command status list. \
+	    local -n pstat=$$2; \
+	  # Cmd: Command Name \
+	    Cmd="$$3"; \
+	  # CmdRunIndex: Index value of Cmd executing in the pipeline. \
+	  # Ex. pipeline = "Cmd1 | Cmd2 | Cmd3 | Cmd1 | Cmd4 | Cmd3" \
+	  # CmdRunIndex of Cmd1(First Time): 1 \
+	  # CmdRunIndex of Cmd2(First Time): 1 \
+	  # CmdRunIndex of Cmd1(Second Time): 4 \
+	    CmdRunIndex="$$4"; \
+	  # CmdRunIndexList: Index List of each Cmd. \
+	  # Ex. pipeline = "Cmd1 | Cmd2 | Cmd1 | Cmd3" \
+	  #     CmdRunIndexList of Cmd1: (1,3) \
+	    CmdRunIndexList=($$(echo $$1 | awk -F'|' '{for(i=1;i<=NF;i++) {gsub(/^[ \t]+|[ \t]+$$/, "", $$i); print $$i}}' | awk -v Cmd_Pattern="$$Cmd " '$$0~Cmd_Pattern {print NR}')); \
+	    for CmdIndex in "$${CmdRunIndexList[@]}"; do \
+	      if [ -v CmdStatus["$$Cmd"] ]; then \
+	         ArrString=$${CmdStatus["$$Cmd"]}; \
+	         ArrString+=",$${pstat[$$CmdIndex-1]}"; \
+	         CmdStatus["$$Cmd"]=$${ArrString}; \
+	      else \
+	         NewArrString=$${pstat[$$CmdIndex-1]}; \
+	         CmdStatus["$$Cmd"]=$${NewArrString}; \
+	      fi; \
+	    done; \
+	    if [ -v CmdStatus[$$Cmd] ] && [ $$CmdRunIndex -gt 0 ];then \
+	       IFS=',' read -ra CmdStatusList <<< "$${CmdStatus[$$Cmd]}"; \
+	       return $${CmdStatusList["$$CmdRunIndex"-1]}; \
+	    fi; \
+	  }; \
+	  pipeline="$(RUNENV) $(SMOKE_TIMEOUT) $(RUNPROF) $(RUNPROF_FLAGS) $(CHECK_COMMAND) > /dev/null 2>&1"; \
+	  $(RUNENV) $(SMOKE_TIMEOUT) $(RUNPROF) $(RUNPROF_FLAGS) $(CHECK_COMMAND) > /dev/null 2>&1; \
+	  pipestatus=($${PIPESTATUS[@]}); \
+	  GetPipedCmdStatus "$$pipeline" "pipestatus" "$(TESTNAME)" "1"; \
+	  test_status=$$?; \
+	  GetPipedCmdStatus "$$pipeline" "pipestatus" "FileCheck" "1"; \
+	  filecheck_status=$$?; \
+	  echo "$$test_status" > TEST_STATUS; \
+	  echo "$$filecheck_status" > FILECHECK_STATUS; \
+	  echo $$base $$test_num return code: $$test_status >> ../check-smoke-asan.txt; \
+	  echo  "" >> ../check-smoke-asan.txt; \
+	  if [ $$filecheck_status -eq 0 ]; then echo $$base $$test_num >> ../passing-tests.txt; \
+	                                   else echo $$base $$test_num >> ../failing-tests.txt; fi; \
+	)9>../lockfile;
 else
-       @echo "  $(SKIP_RUN_UNSUPPORTED)"
+	@echo "  $(SKIP_RUN_UNSUPPORTED)"
 endif
 else
-       @echo "  $(SKIP_RUN_SUPPORTED)"
+	@echo "  $(SKIP_RUN_SUPPORTED)"
 endif
 
+
 # ----- Demo compile and link to object file
 ifneq ($(TESTNAME), $(findstring $(TESTNAME),$(TESTNAMES_ALL)))
 .PHONY: $(TESTNAME).o

test/smoke/check_smoke.sh

@@ -242,7 +242,7 @@ if [ "$AOMP_PARALLEL_SMOKE" == 1 ]; then
         sem --jobs 4 --id def_sem -u 'base=$(basename $(pwd)); make check > /dev/null; if [ $? -ne 0 ]; then flock -e lockfile -c "echo $base: Make Failed >> ../make-fail.txt"; fi;'
       elif [ $base == "gpus" ]; then # Compile and link only test
         echo gpus is compile only!
-      elif [ "$AOMP_SANITIZER" == 1 ]; then
+      elif [ "$AOMP_SANITIZER" == 1 ] && [ "$SMOKE_DIRS" == "smoke-asan" ]; then
         sem --jobs 4 --id def_sem -u 'make check-asan > /dev/null 2>&1'
       else
         sem --jobs 4 --id def_sem -u 'make check > /dev/null 2>&1'
@@ -337,7 +337,7 @@ for directory in $SMOKE_DIRS; do
     echo "$base" >> ../passing-tests.txt
   elif [ $base == 'printf_parallel_for_target' ] || [ $base == 'omp_places' ] || [ $base == 'pfspecifier' ] || [ $base == 'pfspecifier_str' ] ; then
     make verify-log
-  elif [ "$AOMP_SANITIZER" == 1 ]; then
+  elif [ "$AOMP_SANITIZER" == 1 ] && [ "$SMOKE_DIRS" == "smoke-asan" ]; then
     make check-asan > /dev/null 2>&1
   else
     make check > /dev/null 2>&1