feat(auth): add GET /auth/jwt/portal-logout for cross-app logout chain#24
Open
awais786 wants to merge 1 commit into
Open
feat(auth): add GET /auth/jwt/portal-logout for cross-app logout chain#24awais786 wants to merge 1 commit into
awais786 wants to merge 1 commit into
Conversation
e3a1744 to
17bd7d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `GET /auth/jwt/portal-logout?next=` so the foss-server-bundle portal's "Log out of all apps" button can include SurfSense in its cross-origin redirect chain.
Same pattern as Plane MODSetter#35 / Outline #24 / Penpot #24. Reuses SurfSense's existing `revoke_all_user_tokens` primitive (the same one `/auth/jwt/logout-all` uses).
Behaviour
`GET /auth/jwt/portal-logout?next=<absolute_url>`:
Files
`2 files changed, 76 insertions(+), 1 deletion(-)`:
Force-logout risk
GET endpoints are reachable via `
`. For SurfSense the impact is revoking every refresh token for the user, which kicks them out of all devices — not just the current browser. Higher impact than Outline/Penpot (cookie-only clear).
Tradeoff accepted because:
Out of scope
Coordination
Sister PRs: