Compatch for WtWSMS 0.1.8.5 (#3070) #minor

- Updated removable_file_blocks_wtwsms.txt for latest WtWSMS.
- Added a separate province mappings file for Invictus -> WtWSMS
conversions, needed at least until WtWSMS adds playable East Asia.
- Disabled the East Asian Rome division regions for WtWSMS.
- Fixed `k_xia` not having any de jure empire. Previously the converter
tried to assign an empire based on the dominant heritage in the kingdom
(Chinese), but because the Chinese heritage has intentionally no
heritage->empire mapping, the kingdom was skipped. Now the converter
iterates over all heritages in the kingdom (from dominant to least
present) until a usable heritage is found.
- Fixed Rome division regions to work with the WtWSMS de jure setup. Now
the resulting empires are roughly the same as in a vanilla CK3
conversion. Here's a result for I:R Rome owning the entire map:
<img width="1378" height="874" alt="obraz"
src="https://github.com/user-attachments/assets/02bc2abd-375a-41e6-b2ab-df8d2b426371"
/>
<img width="1421" height="878" alt="obraz"
src="https://github.com/user-attachments/assets/a03af871-c8b4-447f-a981-e0061e2daec1"
/>

closes #3056

Author: IhateTrains

.github/workflows/build_dev_version.yml

@@ -54,7 +54,6 @@ jobs:
         onlyPrefix: 'ImperatorToCK3-${{ matrix.build }}-dev-${{ env.BRANCH_NAME }}'
     - uses: actions/checkout@v6
       with:
-        fetch-depth: 0
         submodules: recursive
     - name: "Setup Dotnet for use with actions"
       # don't run on self-hosted Windows

.github/workflows/integration_tests.yml

@@ -24,7 +24,6 @@ jobs:
     steps:
     - uses: actions/checkout@v6
       with:
-        fetch-depth: 0
         submodules: recursive
     - name: "Check if docs folders exist"
       run: |

.github/workflows/spelling.yml

@@ -23,5 +23,6 @@ jobs:
             **/*_l_polish.yml
             **/*_l_korean.yml
             **/*_l_german.yml
+            ImperatorToCK3/Data_Files/configurables/province_mappings/invictus_to_wtwsms.txt
             
 

.github/workflows/steam_mod_update_notifier.yml

@@ -18,6 +18,9 @@ jobs:
   check-steam-mod-updates:
     runs-on: ubuntu-latest
     steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
       - name: Check Steam Workshop mods and notify
         shell: bash
         env:

.github/workflows/test.yml

@@ -14,7 +14,6 @@ jobs:
     steps:
     - uses: actions/checkout@v6
       with:
-        fetch-depth: 0
         submodules: recursive
     - name: "Setup Dotnet for use with actions"
       uses: actions/setup-dotnet@v5
@@ -54,7 +53,6 @@ jobs:
     steps:
     - uses: actions/checkout@v6
       with:
-        fetch-depth: 0
         submodules: recursive
     - name: "Setup Dotnet for use with actions"
       # don't run on self-hosted Windows

ImperatorToCK3.UnitTests/CK3/Characters/CharacterCollectionTests.cs

@@ -273,6 +273,14 @@ public void ImperatorCountriesGoldCanBeDistributedAmongRulerAndVassals() {
 			ruler_term={ character=1000 start_date=440.10.1 }
 		");
 		var country = Country.Parse(countryReader, 589);
+		
+		imperatorWorld.Provinces[1].OwnerCountry = country;
+		imperatorWorld.Provinces[2].OwnerCountry = country;
+		imperatorWorld.Provinces[3].OwnerCountry = country;
+		imperatorWorld.Provinces[4].OwnerCountry = country;
+		imperatorWorld.Provinces[5].OwnerCountry = country;
+		imperatorWorld.Provinces[6].OwnerCountry = country;
+		
 		Assert.Equal(200, country.Currencies.Gold);
 		imperatorWorld.Countries.Add(country);
 		imperatorWorld.Characters.LinkCountries(imperatorWorld.Countries);
@@ -499,9 +507,9 @@ private static void SetPrivateProperty(object target, string propertyName, objec
 		var targetType = target.GetType();
 		var property = targetType.GetProperty(propertyName, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic);
 		Assert.NotNull(property);
-		var setter = property!.GetSetMethod(nonPublic: true);
+		var setter = property.GetSetMethod(nonPublic: true);
 		Assert.NotNull(setter);
-		setter!.Invoke(target, new[] { value });
+		setter.Invoke(target, [value]);
 	}
 
 	private static ImperatorRulerTerm CreateRulerTerm(Date startDate, string governmentId) {

ImperatorToCK3.UnitTests/CK3/Titles/LandedTitlesTests.cs

@@ -235,22 +235,33 @@ public void GovernorshipsCanBeRecognizedAsCountyLevel() {
 		var config = new Configuration { ImperatorPath = "TestFiles/LandedTitlesTests/Imperator" };
 		var imperatorWorld = new TestImperatorWorld(config);
 
-		imperatorWorld.Provinces.Add(new Province(1));
-		imperatorWorld.Provinces.Add(new Province(2));
-		imperatorWorld.Provinces.Add(new Province(3));
+		var irProv1 = new Province(1);
+		var irProv2 = new Province(2);
+		var irProv3 = new Province(3);
+		imperatorWorld.Provinces.Add(irProv1);
+		imperatorWorld.Provinces.Add(irProv2);
+		imperatorWorld.Provinces.Add(irProv3);
 
 		var governor = new ImperatorToCK3.Imperator.Characters.Character(25212);
 		imperatorWorld.Characters.Add(governor);
 
 		var countryReader = new BufferedReader("tag=PRY capital=1");
 		var country = Country.Parse(countryReader, 589);
+		irProv1.OwnerCountry = country;
+		irProv2.OwnerCountry = country;
+		irProv3.OwnerCountry = country;
+		country.RegisterProvince(irProv1);
+		country.RegisterProvince(irProv2);
+		country.RegisterProvince(irProv3);
 		imperatorWorld.Countries.Add(country);
 
 		imperatorWorld.Areas.LoadAreas(imperatorWorld.ModFS, imperatorWorld.Provinces);
 		var irRegionMapper = new ImperatorRegionMapper(imperatorWorld.Areas, irMapData);
 		irRegionMapper.LoadRegions(imperatorWorld.ModFS, new ColorFactory());
 		Assert.True(irRegionMapper.RegionNameIsValid("galatia_area"));
 		Assert.True(irRegionMapper.RegionNameIsValid("galatia_region"));
+		Assert.True(irRegionMapper.ProvinceIsInRegion(2, "galatia_region"));
+		Assert.True(irRegionMapper.ProvinceIsInRegion(3, "galatia_region"));
 		var ck3RegionMapper = new CK3RegionMapper();
 
 		var reader = new BufferedReader(
@@ -335,14 +346,14 @@ public void GovernorshipsCanBeRecognizedAsCountyLevel() {
 			title => Assert.Equal("d_IRTOCK3_PRY", title.Id)
 		);
 
-		var provinces = new ProvinceCollection(ck3ModFS);
+		var ck3Provinces = new ProvinceCollection(ck3ModFS);
 		var ck3MapData = new MapData(ck3ModFS);
 		ck3MapData.ProvinceDefinitions.Add(new(1));
 		ck3MapData.ProvinceDefinitions.Add(new(2));
 		ck3MapData.ProvinceDefinitions.Add(new(3));
-		provinces.ImportImperatorProvinces(imperatorWorld, ck3MapData, titles, cultureMapper, religionMapper, provinceMapper, conversionDate, config);
+		ck3Provinces.ImportImperatorProvinces(imperatorWorld, ck3MapData, titles, cultureMapper, religionMapper, provinceMapper, conversionDate, config);
 		// Country 589 is imported as duchy-level title, so its governorship of galatia_region will be county level.
-		titles.ImportImperatorGovernorships(imperatorWorld, provinces, tagTitleMapper, irLocDB, ck3LocDB, config, provinceMapper, definiteFormMapper, irRegionMapper, coaMapper, countyLevelGovernorships);
+		titles.ImportImperatorGovernorships(imperatorWorld, ck3Provinces, tagTitleMapper, irLocDB, ck3LocDB, config, provinceMapper, definiteFormMapper, irRegionMapper, coaMapper, countyLevelGovernorships);
 
 		Assert.Collection(titles,
 			title => Assert.Equal("c_county1", title.Id),
@@ -610,6 +621,68 @@ public void TitlesCanBeExpandedInOtherFiles() {
 		Assert.Equal("c_karakorum", mongoliaKingdom.CapitalCountyId);
 	}
 
+	[Fact]
+	public void KingdomUsesNextDominantHeritageWhenMostDominantOneCannotProvideEmpire() {
+		var date = new Date(867, 1, 1);
+		var titles = new Title.LandedTitles();
+		titles.LoadTitles(new BufferedReader(
+			"e_mongolia = { }\n" +
+			"k_test = {\n" +
+			"\td_test = {\n" +
+			"\t\tc_county1 = { b_barony1 = { province = 1 } }\n" +
+			"\t\tc_county2 = { b_barony2 = { province = 2 } }\n" +
+			"\t\tc_county3 = { b_barony3 = { province = 3 } }\n" +
+			"\t}\n" +
+			"}\n" +
+			"k_xia = {\n" +
+			"\td_xia = {\n" +
+			"\t\tc_xia_county = { b_xia_barony = { province = 4 } }\n" +
+			"\t}\n" +
+			"}\n"
+		), colorFactory);
+
+		var cultureCollection = new TestCK3CultureCollection();
+		cultureCollection.GenerateTestCulture("han", "heritage_chinese");
+		cultureCollection.GenerateTestCulture("mongol", "heritage_mongolic");
+
+		var characters = new CharacterCollection();
+		var hanHolder1 = new Character("1", "Han Holder 1", new Date(800, 1, 1), characters);
+		hanHolder1.SetCultureId("han", null);
+		characters.Add(hanHolder1);
+
+		var hanHolder2 = new Character("2", "Han Holder 2", new Date(801, 1, 1), characters);
+		hanHolder2.SetCultureId("han", null);
+		characters.Add(hanHolder2);
+
+		var mongolHolder = new Character("3", "Mongol Holder", new Date(802, 1, 1), characters);
+		mongolHolder.SetCultureId("mongol", null);
+		characters.Add(mongolHolder);
+
+		titles["c_county1"].SetHolder(hanHolder1, date);
+		titles["c_county2"].SetHolder(hanHolder2, date);
+		titles["c_county3"].SetHolder(mongolHolder, date);
+		titles["c_xia_county"].SetHolder(mongolHolder, date);
+
+		var heritageMapPath = Path.Combine("configurables", "heritage_empires_map.txt");
+		var originalHeritageMap = File.Exists(heritageMapPath) ? File.ReadAllText(heritageMapPath) : null;
+		Directory.CreateDirectory("configurables");
+		File.WriteAllText(heritageMapPath,
+			"heritage_chinese = none\n" +
+			"heritage_mongolic = e_mongolia\n");
+
+		try {
+			titles.SetDeJureKingdomsAndAbove(date, cultureCollection, characters, new MapData(ck3ModFS), new CK3RegionMapper(), new TestCK3LocDB());
+
+			Assert.Equal("e_mongolia", titles["k_test"].DeJureLiege?.Id);
+		} finally {
+			if (originalHeritageMap is null) {
+				File.Delete(heritageMapPath);
+			} else {
+				File.WriteAllText(heritageMapPath, originalHeritageMap);
+			}
+		}
+	}
+
 	[Fact]
 	public void RemoveBreaksAllLinks() {
 		var landedTitles = new Title.LandedTitles();

ImperatorToCK3/CK3/Titles/LandedTitles.cs

@@ -265,7 +265,7 @@ IReadOnlyCollection<string> enabledCK3Dlcs
 			return newTitle;
 		}
 
-		internal Title Add(
+		private Title Add(
 			string id,
 			Governorship governorship,
 			Country country,
@@ -778,6 +778,11 @@ List<Governorship> countyLevelGovernorships
 			// add new ones from Imperator governorships.
 			var counter = 0;
 			foreach (var governorship in governorships) {
+				// Don't import if the governorship has no I:R provinces.
+				if (governorship.GetIRProvinceCount(irWorld.Provinces) == 0) {
+					continue;
+				}
+
 				ImportImperatorGovernorship(
 					governorship,
 					this,
@@ -819,7 +824,8 @@ Configuration config
 
 			var id = DetermineId(governorship, titles, irProvinces, ck3Provinces, imperatorRegionMapper, tagTitleMapper, provinceMapper);
 			if (id is null) {
-				Logger.Warn($"Cannot convert {governorship.Region.Id} of country {country.Id}");
+				Logger.Warn($"Cannot convert {governorship.Region.Id} of country {country.Id}. " +
+				            $"I:R provinces: {string.Join(", ", governorship.GetIRProvinces(irProvinces).Select(p => p.Id))}");
 				return;
 			}
 
@@ -1388,21 +1394,23 @@ Date ck3BookmarkDate
 				}
 				kingdomToDominantHeritagesDict[kingdom.Id] = dominantHeritages;
 
-				var dominantHeritage = dominantHeritages[0];
-
-				if (heritageToEmpireDict.TryGetValue(dominantHeritage.Id, out var empire)) {
-					if (empire is null) {
-						// The heritage is not supposed to have an empire.
-						continue;
+				foreach (var dominantHeritage in dominantHeritages) {
+					if (heritageToEmpireDict.TryGetValue(dominantHeritage.Id, out var empire)) {
+						if (empire is null) {
+							// The heritage is not supposed to have an empire, try the next dominant heritage.
+							continue;
+						}
+						kingdom.DeJureLiege = empire;
+						break;
 					}
-					kingdom.DeJureLiege = empire;
-				} else {
-					// Create new de jure empire based on heritage.
+
+					// Create new de jure empire based on the first usable heritage.
 					var heritageEmpire = CreateEmpireForHeritage(dominantHeritage, ck3Cultures, ck3LocDB);
 					removableEmpireIds.Add(heritageEmpire.Id);
 
 					kingdom.DeJureLiege = heritageEmpire;
 					heritageToEmpireDict[dominantHeritage.Id] = heritageEmpire;
+					break;
 				}
 			}
 		}

ImperatorToCK3/CK3/World.cs

@@ -551,7 +551,7 @@ private void ImportImperatorWars(Imperator.World irWorld, Date ck3BookmarkDate)
 	private void LoadCorrectProvinceMappingsFile(Imperator.World irWorld, Configuration config) {
 		// Terra Indomita mappings should be used if either TI or Antiquitas is detected.
 		bool irHasTI = config.TerraIndomitaDetected;
-		
+
 		bool ck3HasRajasOfAsia = config.RajasOfAsiaEnabled;
 		bool ck3HasAEP = config.AsiaExpansionProjectEnabled;
 
@@ -562,6 +562,8 @@ private void LoadCorrectProvinceMappingsFile(Imperator.World irWorld, Configurat
 			mappingsToUse = "terra_indomita_to_aep";
 		} else if (irHasTI) {
 			mappingsToUse = "terra_indomita_to_vanilla_ck3";
+		} else if (config.WhenTheWorldStoppedMakingSenseEnabled) {
+			mappingsToUse = "invictus_to_wtwsms";
 		} else if (config is {InvictusDetected: true, Invictus1_7Detected: true}) {
 			mappingsToUse = "invictus_1_7_to_vanilla_ck3";
 		} else if (config.InvictusDetected) {

ImperatorToCK3/Configuration.cs

@@ -6,7 +6,6 @@
 using ImperatorToCK3.CommonUtils;
 using System;
 using System.Collections.Generic;
-using System.Globalization;
 using System.IO;
 using System.Linq;