Skip to content

Commit bd57448

Browse files
NitjsefnieKimi K3
andcommitted
requirements-dev: pin matplotlib so the types gate can resolve it
Refs #9. scripts/plots/ccusage_*.py imports matplotlib, but nothing in CI's types workflow installed it, so pyright reported 8 reportMissingImports errors there (locally it resolves via the system python's 3.10.8, which is why the miss did not show up here). matplotlib is an analyst-side plotting dependency — backend code never imports it — so it belongs in the dev/toolchain pins, not backend/requirements.txt. Co-Authored-By: Kimi K3 <[email protected]>
1 parent 117d2a2 commit bd57448

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

requirements-dev.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,8 @@ isort==8.0.1
88
pycodestyle==2.14.0
99
pylint==4.0.6
1010
pyright==1.1.408
11+
# Not a tool: the types gate installs this file so pyright can resolve
12+
# third-party imports, and scripts/plots/ccusage_*.py imports matplotlib.
13+
# It is an analyst-side plotting dependency, not a backend runtime dep,
14+
# so it does not belong in backend/requirements.txt.
15+
matplotlib==3.10.8

0 commit comments

Comments
 (0)