From 73beb1843ee3545219e14269ae49b4c6f3edfb03 Mon Sep 17 00:00:00 2001 From: Nikolay Samokhvalov Date: Sat, 18 Jul 2026 12:43:38 +0000 Subject: [PATCH] ci: enable wal_consistency_checking in Linux Meson (64-bit) task WAL consistency checking (027_stream_regress running the full regression suite through a streaming standby with wal_consistency_checking = all) is resource intensive, so the test only turns it on when PG_TEST_EXTRA contains "wal_consistency_checking". No CI task set that, so this valuable check -- verifying that WAL redo reconstructs byte-identical pages on a standby -- had effectively zero coverage in CI. Extend the workflow-level PG_TEST_EXTRA on the Linux - Meson (64-bit) task so 027_stream_regress exercises WAL redo consistency. It's scoped to the "Test world" step of a single Linux task to keep the added cost contained. Locally the run went from ~63s to ~89s wall-clock (11 subtests passing), a modest cost for a heavily used replication task. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01PtxA6B4d47ietk5dGsseuP --- .github/workflows/pg-ci.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/pg-ci.yml b/.github/workflows/pg-ci.yml index a2629c8335a1b..89f07d5d4009e 100644 --- a/.github/workflows/pg-ci.yml +++ b/.github/workflows/pg-ci.yml @@ -627,6 +627,8 @@ jobs: # faster at running the tests. # - Uses io_method=io_uring # - Uses meson feature autodetection + # - Enables wal_consistency_checking (opt-in via PG_TEST_EXTRA) so that + # 027_stream_regress exercises WAL redo consistency across a standby linux-meson-64: name: Linux - Meson (64-bit) needs: [setup, sanity-check] @@ -668,6 +670,13 @@ jobs: - name: Test world shell: *su_postgres_shell + # Extend the workflow-level PG_TEST_EXTRA with + # wal_consistency_checking. It's resource intensive so it's opt-in and + # not covered by any other task; enabling it here makes + # 027_stream_regress verify that WAL redo produces byte-identical pages + # on the standby. + env: + PG_TEST_EXTRA: ${{env.PG_TEST_EXTRA}} wal_consistency_checking run: *meson_test_world_cmd - *linux_collect_cores_step