fix(ivy): support view references in insertBefore (#2258)

edusperoni · web-flow · commit c2eaef52a66d · 2020-09-20T18:27:37.000-07:00
diff --git a/nativescript-angular/renderer.ts b/nativescript-angular/renderer.ts
@@ -31,7 +31,8 @@ export class NativeScriptRenderer extends Renderer2 {
 	}
 
 	@profile
-	insertBefore(parent: NgView, newChild: NgView, { previous, next }: ElementReference): void {
+	insertBefore(parent: NgView, newChild: NgView, refChild: NgView | ElementReference): void {
+		let { previous, next } = refChild instanceof View ? this.nextSibling(refChild) : refChild;
 		if (NativeScriptDebug.isLogEnabled()) {
 			NativeScriptDebug.rendererLog(`NativeScriptRenderer.insertBefore child: ${newChild} ` + `parent: ${parent} previous: ${previous} next: ${next}`);
 		}

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@ export class NativeScriptRenderer extends Renderer2 {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`@profile`
`34`		`- insertBefore(parent: NgView, newChild: NgView, { previous, next }: ElementReference): void {`
	`34`	`+ insertBefore(parent: NgView, newChild: NgView, refChild: NgView \| ElementReference): void {`
	`35`	`+ let { previous, next } = refChild instanceof View ? this.nextSibling(refChild) : refChild;`
`35`	`36`	`if (NativeScriptDebug.isLogEnabled()) {`
`36`	`37`	NativeScriptDebug.rendererLog(`NativeScriptRenderer.insertBefore child: ${newChild} ` + `parent: ${parent} previous: ${previous} next: ${next}`);
`37`	`38`	`}`