Skip to content

Commit f69a3f7

Browse files
committed
skill refinement
Signed-off-by: Sam Oluwalana <[email protected]>
1 parent 7e6c524 commit f69a3f7

29 files changed

Lines changed: 471 additions & 302 deletions

File tree

docs/set-up/config-reference.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,8 @@ jobs:
409409
reconcile_interval_seconds: 2
410410
# Interval in seconds for the job scheduler to run | default: 5
411411
schedule_interval_seconds: 5
412+
# Register the subprocess/default execution profile. When unset, defaults to true for docker/none runtimes and false for kubernetes.
413+
enable_subprocess_executor:
412414
```
413415

414416
### `models`

packages/nemo_platform_plugin/src/nemo_platform_plugin/discovery.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@
5252
if TYPE_CHECKING:
5353
from nemo_platform_plugin.cli import NemoCLI
5454
from nemo_platform_plugin.controller import NemoController
55-
from nemo_platform_plugin.function import NemoFunction
5655
from nemo_platform_plugin.customization_contributor import CustomizationContributor
56+
from nemo_platform_plugin.function import NemoFunction
5757
from nemo_platform_plugin.inference_middleware import NemoInferenceMiddleware
5858
from nemo_platform_plugin.job import NemoJob
5959
from nemo_platform_plugin.seed import NemoSeedJob
@@ -501,7 +501,6 @@ def discover_customization_contributors() -> dict[str, CustomizationContributor]
501501
instance. Broken contributors are skipped with a warning (same fault isolation as
502502
:func:`discover`).
503503
"""
504-
from nemo_platform_plugin.customization_contributor import CustomizationContributor
505504

506505
result: dict[str, CustomizationContributor] = {}
507506

packages/nemo_platform_plugin/tests/test_authz.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from __future__ import annotations
55

66
import pytest
7-
87
from nemo_platform_plugin.authz import AuthzContribution, authz_for_workspace_job_collection
98
from nemo_platform_plugin.authz_discovery import _collect_from_plugin_surface, discover_authz_contributions
109
from nemo_platform_plugin.service import NemoService

plugins/nemo-automodel/src/nemo_automodel_plugin/config.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
from __future__ import annotations
77

8-
import os
9-
108
from pydantic_settings import BaseSettings, SettingsConfigDict
119

1210

plugins/nemo-automodel/src/nemo_automodel_plugin/contributor.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,15 @@ async def healthz() -> dict[str, str]:
5656
]
5757

5858
def get_cli(self) -> typer.Typer:
59-
from nemo_automodel_plugin.cli.inputs import apply_automodel_job_cli_overrides
6059
from nemo_platform_plugin.commands import (
6160
_add_explain_command,
6261
_add_run_command,
6362
_add_submit_command,
6463
)
6564
from nemo_platform_plugin.scheduler import NemoJobScheduler
6665

66+
from nemo_automodel_plugin.cli.inputs import apply_automodel_job_cli_overrides
67+
6768
app = typer.Typer(
6869
name=self.name,
6970
help="Automodel training jobs (SFT, distillation).",

plugins/nemo-automodel/src/nemo_automodel_plugin/sdk/http_utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88
from typing import Any
99
from urllib.parse import quote, urljoin
1010

11-
from nemo_automodel_plugin.schema import AutomodelJobInput
1211
from nemo_platform import AsyncNeMoPlatform, NeMoPlatform
1312

13+
from nemo_automodel_plugin.schema import AutomodelJobInput
14+
1415
PlatformClient = NeMoPlatform | AsyncNeMoPlatform
1516

1617
_API_PREFIX = "/apis/customization"

plugins/nemo-automodel/src/nemo_automodel_plugin/sdk/job_resources.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
from typing import Any
99
from urllib.parse import quote
1010

11-
from nemo_automodel_plugin.sdk import http_utils
12-
from nemo_platform import AsyncNeMoPlatform, NeMoPlatform
1311
from nemo_platform_plugin.jobs.schemas import PlatformJobStatusResponse
1412
from pydantic import BaseModel
1513

14+
from nemo_automodel_plugin.sdk import http_utils
15+
1616

1717
class AutomodelJobRecord(BaseModel):
1818
"""Minimal job record returned by the customization Automodel jobs API."""

plugins/nemo-automodel/src/nemo_automodel_plugin/sdk/resources.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@
77

88
from typing import Any
99

10+
from nemo_platform import AsyncNeMoPlatform, NeMoPlatform
11+
1012
from nemo_automodel_plugin.schema import AutomodelJobInput
1113
from nemo_automodel_plugin.sdk import http_utils
1214
from nemo_automodel_plugin.sdk.job_resources import (
1315
AsyncAutomodelJobResource,
1416
AutomodelJobRecord,
1517
AutomodelJobResource,
1618
)
17-
from nemo_platform import AsyncNeMoPlatform, NeMoPlatform
1819

1920

2021
class AutomodelJobsResource:

plugins/nemo-automodel/src/nemo_automodel_plugin/transform.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
import uuid
99
from typing import TYPE_CHECKING
1010

11+
from nmp.automodel.platform_client import check_dataset_access, fetch_model_entity
12+
from nmp.common.entities.utils import parse_entity_ref
13+
1114
from nemo_automodel_plugin.schema import (
1215
AutomodelJobInput,
1316
AutomodelJobOutput,
14-
OutputRequest,
1517
OutputResponse,
1618
)
17-
from nmp.automodel.platform_client import check_dataset_access, fetch_model_entity
18-
from nmp.common.entities.utils import parse_entity_ref
1919

2020
if TYPE_CHECKING:
2121
from nemo_platform import AsyncNeMoPlatform

plugins/nemo-automodel/tests/test_cli.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,5 +122,3 @@ def test_cli_expose_input_and_output_schemas() -> None:
122122
assert "input_spec_schema" in payload
123123
assert "spec_schema" in payload
124124
assert "/automodel/jobs" in payload["endpoint"]
125-
126-

0 commit comments

Comments
 (0)