self review

Author: withjannisNLnetLabs

src/base/iana/exterr.rs

@@ -158,13 +158,13 @@ int_enum! {
 
     /// The client tried to use QUIC session Zero Round Trip Time (0-RTT) with
     /// a non-replayable transaction. The server is not allowed to process
-    /// that and therefore respons with this error.
+    /// that and therefore responds with this error.
     (TOO_EARLY => 26, "Too Early")
 
     /// The resolver encountered an NSEC3 iteration value greater than 0.
     (UNSUPPORTED_NSEC3_ITERATIONS_VALUE => 27, "Unsupported NSEC3 Iterations Value")
 
-    /// The error is returned the proxy cannot meet the requirements in a
+    /// The error is returned when the proxy cannot meet the requirements in a
     /// PROXY CONTROL Option or the option is malformed.
     (UNABLE_TO_CONFORM_TO_POLICY => 28, "Unable to conform to policy")
 
@@ -186,7 +186,7 @@ int_enum! {
     /// queried name, disabling DNSSEC validation.
     (NEGATIVE_TRUST_ANCHOR => 33, "Negative Trust Anchor")
 
-    /// When there is no NS records for a delegated zone.
+    /// When there are no NS records for a delegated zone.
     (NEW_DELEGATION_ONLY => 34, "New Delegation Only")
 }
 

src/base/iana/ipseckey.rs

@@ -47,7 +47,7 @@ int_enum! {
     /// the gateway field of the [IPSECKEY].
     ///
     /// For the currently registered values see the [IANA registration]. This
-    /// type is complete as of 2025-09-09.
+    /// type is complete as of the registry update of 2023-03-15.
     ///
     /// [IPSECKEY]: ../../../rdata/ipseckey/index.html
     /// [IANA registration]: https://www.iana.org/assignments/ipseckey-rr-parameters/ipseckey-rr-parameters.xhtml#ipseckey-rr-parameters-2

src/base/iana/opt.rs

@@ -189,7 +189,7 @@ int_enum! {
     /// a DNS QUERY (OpCode=0). Defined in [RFC-ietf-dnssd-multi-qtypes].
     ///
     /// [RFC-ietf-dnssd-multi-qtypes]: https://datatracker.ietf.org/doc/html/draft-ietf-dnssd-multi-qtypes
-    (MQTYPEQUERY => 20, "MQTYPE-Query")
+    (MQTYPE_QUERY => 20, "MQTYPE-Query")
 
     /// MQTYPE-Response (21).
     ///
@@ -198,7 +198,7 @@ int_enum! {
     /// (OpCode=0). Defined in [RFC-ietf-dnssd-multi-qtypes].
     ///
     /// [RFC-ietf-dnssd-multi-qtypes]: https://datatracker.ietf.org/doc/html/draft-ietf-dnssd-multi-qtypes
-    (MQTYPERESPONSE => 21, "MQTYPE-Response")
+    (MQTYPE_RESPONSE => 21, "MQTYPE-Response")
 
     /// EDE-EXTRA-TEXT-LANGUAGE (22).
     ///
@@ -240,7 +240,7 @@ int_enum! {
     /// which a matched query caused the filtering to occur.
     /// Defined in [draft-muks-dns-filtering].
     ///
-    /// [draft-muks-dns-filtering]: https://datatracker.ietf.org/doc/html/draft-muks-dns-filtering#name-filtering-organization-edns
+    /// [draft-muks-dns-filtering]: https://datatracker.ietf.org/doc/html/draft-muks-dns-filtering#name-filtering-db-edns-option
     (FILTERING_DB => 25, "FILTERING-DB")
 
     /// Umbrella Ident (20292).
@@ -252,7 +252,7 @@ int_enum! {
 
     /// DeviceID (26946).
     ///
-    /// Ths option is used by the [Cisco Umbrella network device API].
+    /// This option is used by the [Cisco Umbrella network device API].
     ///
     /// [Cisco Umbrella network device API]: https://developer.cisco.com/docs/cloud-security/network-devices-with-cisco-umbrella-dns/#network-devices-with-cisco-umbrella-dns
     (DEVICE_ID => 26946, "DeviceId")

src/base/iana/rtype.rs

@@ -453,7 +453,7 @@ int_enum! {
     /// See draft-johnson-dns-ipn-cla-07.
     (CLA => 263, "CLA")
 
-    /// CLA BP Convergence Layer Adapter.
+    /// IPN BP Node Number.
     ///
     /// See draft-johnson-dns-ipn-cla-07.
     (IPN => 264, "IPN")

src/base/iana/secalg.rs

@@ -103,12 +103,16 @@ int_enum! {
 
     /// SM2 signing algorithm with SM3 hashing algorithm
     ///
-    /// This algorithm is described in RFC 9558.
+    /// This algorithm is described in [RFC 9563].
+    ///
+    /// [RFC 9563]: https://datatracker.ietf.org/doc/html/rfc9563
     (SM2SM3 => 17, "SM2SM3")
 
     /// GOST R 34.10-2012
     ///
-    /// This algorithm is described in RFC 9558.
+    /// This algorithm is described in [RFC 9558].
+    ///
+    /// [RFC 9558]: https://datatracker.ietf.org/doc/html/rfc9558
     (ECC_GOST12 => 23, "ECC-GOST12")
 
     /// Reserved for Indirect Keys

src/base/iana/sshfp.rs

@@ -49,7 +49,7 @@ int_enum! {
     /// This type selects the algorithm of the public key associated with the [`Sshfp`].
     ///
     /// For the currently registered values see the [IANA registration]. This
-    /// type is complete as of 2025-09-04.
+    /// type is complete as of the registry update of 2020-02-25.
     ///
     /// [`Sshfp`]: crate::rdata::sshfp::Sshfp
     /// [IANA registration]: https://www.iana.org/assignments/dns-sshfp-rr-parameters/dns-sshfp-rr-parameters.xhtml#dns-sshfp-rr-parameters-1

src/base/iana/svcb.rs

@@ -88,22 +88,22 @@ int_enum! {
     /// See [RFC9953].
     ///
     /// [RFC9953]: https://datatracker.ietf.org/doc/html/rfc9953#name-selection-of-a-doc-server
-    (DOCPATH => 10, "DOCPATH")
+    (DOCPATH => 10, "docpath")
 
     /// PVD PvD configuration is available at the well-known path.
     ///
     /// See [draft-ietf-intarea-proxy-config].
     ///
     /// [draft-ietf-intarea-proxy-config]: https://datatracker.ietf.org/doc/html/draft-ietf-intarea-proxy-config#section-2.1
-    (PVD => 11, "PVD")
+    (PVD => 11, "pvd")
 
     /// OOTS Per-transport operator confidence in serving the nameserver's
     /// query load over that transport, as a percentage.
     ///
-    /// See [draft-ietf-intarea-proxy-config].
+    /// See [draft-johani-dnsop-svcb-oots].
     ///
-    /// [draft-ietf-intarea-proxy-config]: https://datatracker.ietf.org/doc/html/draft-johani-dnsop-svcb-oots#section-5
-    (OOTS => 12, "OOTS")
+    /// [draft-johani-dnsop-svcb-oots]: https://datatracker.ietf.org/doc/html/draft-johani-dnsop-svcb-oots#section-5
+    (OOTS => 12, "oots")
 }
 
 int_enum_str_with_prefix!(SvcParamKey, "key", b"key", u16, "unknown key");

src/base/iana/zonemd.rs

@@ -9,7 +9,7 @@ int_enum! {
     /// as input to the hashing function for use with [ZONEMD].
     ///
     /// For the currently registered values see the [IANA registration]. This
-    /// type is complete as of 2026-07-06.
+    /// type is complete as of the registry update of 2026-07-06.
     ///
     /// [ZONEMD]: ../../../rdata/zonemd/index.html
     /// [IANA registration]: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#zonemd-schemes
@@ -32,7 +32,7 @@ int_enum! {
     /// the [ZONEMD].
     ///
     /// For the currently registered values see the [IANA registration]. This
-    /// type is complete as of 2024-11-29.
+    /// type is complete as of the registry update of 2026-07-06.
     ///
     /// [ZONEMD]: ../../../rdata/zonemd/index.html
     /// [IANA registration]: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#zonemd-hash-algorithms