Upgrade#25
Conversation
|
|
||
| - name: Log in to GitHub Container Registry | ||
| uses: docker/login-action@v3 | ||
| uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0 |
There was a problem hiding this comment.
changes to github actions are security related
pinning version hashes
scoping secrets to proper workflows
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "bun" | ||
| directory: "/" |
There was a problem hiding this comment.
removed for renovate, but also -- you don't need to merge the dependency PRs
I'm tempted to remove it entirely from children and just have parent always handle dependency version syncing (since inheritance is the advantage here)
| }, | ||
| { | ||
| "matchPackagePatterns": ["^@rspack/", "^@rsbuild/"], | ||
| "allowedVersions": "<2.0.0" |
There was a problem hiding this comment.
Because I noticed you upgraded these to v2, but we're not ready for v2
|
|
||
| export function Shell({ children }: { children: ReactNode }) { | ||
| const pathname = useClientValue(() => window.location.pathname, "/"); | ||
| const matchRoute = useMatchRoute(); |
There was a problem hiding this comment.
tanstack router idiomatic
|
|
||
| function createRpcLink( | ||
| runtimeConfig: { hostUrl: string; rpcBase: string }, | ||
| forwardCookie?: string, |
There was a problem hiding this comment.
this was a workaround, probably cuz rspack was failing so you were trying to get working api
| @@ -1,13 +0,0 @@ | |||
| @import url("https://fonts.googleapis.com/css2?family=Bungee&display=swap"); | |||
There was a problem hiding this comment.
sorry I realized styles.css was getting gitignored
I moved to there, follow standards
| const renderToStream = async (request: Request, renderOptions: RenderOptions) => { | ||
| const url = new URL(request.url); | ||
| const history = createMemoryHistory({ initialEntries: [url.pathname + url.search] }); | ||
| const { hostUrl, rpcBase } = renderOptions.runtimeConfig; |
There was a problem hiding this comment.
shouldn't need these workarounds
| @@ -1,42 +0,0 @@ | |||
| # Files copied on `bos init` but never overwritten on `bos sync`. | |||
| # These are agency-owned — every fork customizes them after init. | |||
There was a problem hiding this comment.
Migrated away from this concept for upgrades
| @@ -1,12 +1,48 @@ | |||
| { | |||
| "extends": "bos://dev.everything.near/everything.dev", | |||
There was a problem hiding this comment.
extending from dev.everything.near
| ] | ||
| } | ||
| }, | ||
| "app": { |
There was a problem hiding this comment.
no need to describe host or auth -- these will stay up to date with parent (dev.everything.near)
2 participants
Makes some updates, see comments