Update task status after the task fails#500
Merged
Merged
Conversation
When Ray head/worker pods are deleted during task execution:
- Task was stuck in RUNNING forever, frontend never updated
Changes:
1. job_task_scheduler.py: Add connection failure counter (5 retries)
+ stall detection (120s no log progress = FAILED)
2. operator_runtime.py: Add GET /api/task/{id}/status endpoint
to expose RayJobScheduler task status to backend-python
3. cleaning_task_scheduler.py: Add background polling loop that
queries runtime status every 2s and updates database on
terminal states (completed/failed/cancelled)
4. operator_runtime.py: get_from_cfg() supports default fallback
- Add _validate_task_id() with UUID regex check for all endpoints accepting task_id in URL path (/submit, /status, /stop) - Add defense-in-depth check in get_from_cfg() rejecting ../ \ characters in task_id - Add PARAM_ERROR error code for invalid parameter responses Fixes CodeQL high-severity: Uncontrolled data used in path expression
Replace inline '../' check with os.path.normpath + startswith prefix validation, which is recognized by CodeQL as a sanitization pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #486