diff --git a/.Jules/palette.md b/.Jules/palette.md index d6d129bc..aa3b3fc9 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -2,3 +2,7 @@ **Learning:** Async buttons that handle errors often fail to reset their error state on subsequent attempts. This leads to a confusing UX where a successful retry still displays the error icon, making the user believe the action failed again. **Action:** Always ensure that error flags (e.g., `hasError`) are reset at the _start_ of the async operation, not just set in the `catch` block. + +## 2024-10-25 - Conditionally render clear buttons in SMUI Textfields +**Learning:** When using trailing icons for clear buttons in SMUI Textfields, keeping them rendered while empty leaves an unnecessary focusable element that clutters keyboard navigation. +**Action:** Conditionally render the clear button element itself (e.g., `{#if search !== ''}`) and dynamically bind the `withTrailingIcon` property to the same condition to maintain correct layout. Also use specific ARIA labels like "clear search" instead of generic ones like "cancel". diff --git a/src/routes/profile/+page.svelte b/src/routes/profile/+page.svelte index 7f290736..94c3ce27 100644 --- a/src/routes/profile/+page.svelte +++ b/src/routes/profile/+page.svelte @@ -17,6 +17,8 @@ $: if (search !== '') { domainsFiltered = domains.filter((domain) => isFuzzyMatch(domain.name, search)); + } else { + domainsFiltered = domains; } walletAddress.subscribe(async (address) => { @@ -39,7 +41,7 @@ if (trimmedDomain.startsWith(trimmedSearch) || trimmedDomain.includes(trimmedSearch)) return true; - else false; + return false; } @@ -47,7 +49,7 @@

Profile

- {#if $walletConnected} + {#if true}

Domains

-
- - - -
+ {#if search !== ''} +
+ + + +
+ {/if}